Merge ~r41k0u/ubuntu/+source/needrestart:ubuntu/oracular-devel into ubuntu/+source/needrestart:ubuntu/oracular-devel

Proposed by Pragyansh Chaturvedi
Status: Needs review
Proposed branch: ~r41k0u/ubuntu/+source/needrestart:ubuntu/oracular-devel
Merge into: ubuntu/+source/needrestart:ubuntu/oracular-devel
Diff against target: 83 lines (+55/-0)
4 files modified
debian/changelog (+11/-0)
debian/patches/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch (+21/-0)
debian/patches/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch (+21/-0)
debian/patches/series (+2/-0)
Reviewer Review Type Date Requested Status
Simon Quigley (community) Needs Fixing
git-ubuntu import Pending
Review via email: mp+476877@code.launchpad.net

Commit message

* Don't restart glusterd automatically (LP: #2085070)
  - d/p/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch:
    Add regex to ignore glusterd for automatic restart
* Don't restart keepalived automatically (LP: #2089155)
  - d/p/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch:
    Add regex to ignore keepalived and for automatic restart

To post a comment you must log in.
5766711... by Pragyansh Chaturvedi

* Don't restart keepalived automatically (LP: #2089155)
   - d/p/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch:
     Add regex to ignore keepalived for automatic restart
   - d/p/series: Add new patch to patch series

8b4e50f... by Pragyansh Chaturvedi

changelog

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Hey! It looks like there has been a security update since you created this patch, could you please rebase it?

Thanks in advance!

review: Needs Fixing
Revision history for this message
Pragyansh Chaturvedi (r41k0u) wrote :

Done!

Unmerged commits

8b4e50f... by Pragyansh Chaturvedi

changelog

5766711... by Pragyansh Chaturvedi

* Don't restart keepalived automatically (LP: #2089155)
   - d/p/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch:
     Add regex to ignore keepalived for automatic restart
   - d/p/series: Add new patch to patch series

527b6c0... by Pragyansh Chaturvedi

* Don't restart glusterd automatically (LP: #2085070)
  - d/p/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch:
    Add regex to ignore glusterd for automatic restart
  - d/p/series: Add new patch to patch series

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 010ada7..917be7c 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,14 @@
6+needrestart (3.6-8ubuntu4.5) oracular; urgency=medium
7+
8+ * Don't restart glusterd automatically (LP: #2085070)
9+ - d/p/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch:
10+ Add regex to ignore glusterd for automatic restart
11+ * Don't restart keepalived automatically (LP: #2089155)
12+ - d/p/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch:
13+ Add regex to ignore keepalived and for automatic restart
14+
15+ -- Pragyansh Chaturvedi <pragyansh.chaturvedi@canonical.com> Tue, 10 Dec 2024 13:26:15 +0530
16+
17 needrestart (3.6-8ubuntu4.4) oracular-security; urgency=medium
18
19 * SECURITY REGRESSION: false positives for killing processes in LXC
20diff --git a/debian/patches/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch b/debian/patches/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch
21new file mode 100644
22index 0000000..1acbe16
23--- /dev/null
24+++ b/debian/patches/lp2085070/0022-ubuntu-avoid-restart-glusterd.patch
25@@ -0,0 +1,21 @@
26+Description: Don't restart glusterd automatically
27+ Add regex to prevent glusterd from restarting
28+ automatically. Glusterd should not automatically restart after
29+ an update. Other services can depend on it and because of that
30+ also get an unwanted / unplanned restart. It should be deferred.
31+Author: Pragyansh Chaturvedi <pragyansh.chaturvedi@canonical.com>
32+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2085070
33+Last-Update: 2024-11-20
34+---
35+
36+--- a/ex/needrestart.conf 2024-12-04 14:22:18.370320503 +0530
37++++ b/ex/needrestart.conf 2024-12-04 14:22:24.755325093 +0530
38+@@ -122,6 +122,8 @@
39+ qr(^google-(shutdown|startup)-scripts\.service$) => 0,
40+ # LP: #2067800
41+ qr(^runner-provisionner\.service$) => 0,
42++ # LP: #2085070
43++ qr(^glusterd\.service$) => 0,
44+
45+ # systemd stuff
46+ # (see also Debian Bug#784238 & #784437)
47diff --git a/debian/patches/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch b/debian/patches/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch
48new file mode 100644
49index 0000000..66f90fe
50--- /dev/null
51+++ b/debian/patches/lp2089155/0023-ubuntu-avoid-restart-keepalived.patch
52@@ -0,0 +1,21 @@
53+Description: Don't restart keepalived automatically
54+ Add regex to prevent keepalived from restarting automatically.
55+ keepalived should not automatically restart after an update.
56+ Other services can depend on it and it's state and might get
57+ disrupted due to an unwanted / unplanned restart. It should be
58+ deferred.
59+Author: Pragyansh Chaturvedi <pragyansh.chaturvedi@canonical.com>
60+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2089155
61+Last-Update: 2024-12-04
62+---
63+--- a/ex/needrestart.conf 2024-12-04 15:12:35.573261273 +0530
64++++ b/ex/needrestart.conf 2024-12-04 15:13:21.364036394 +0530
65+@@ -124,6 +124,8 @@
66+ qr(^runner-provisionner\.service$) => 0,
67+ # LP: #2085070
68+ qr(^glusterd\.service$) => 0,
69++ # LP: #2089155
70++ qr(^keepalived\.service$) => 0,
71+
72+ # systemd stuff
73+ # (see also Debian Bug#784238 & #784437)
74diff --git a/debian/patches/series b/debian/patches/series
75index a693b54..bd90632 100644
76--- a/debian/patches/series
77+++ b/debian/patches/series
78@@ -23,3 +23,5 @@ CVE-2024-48990.patch
79 CVE-2024-48991.patch
80 lp2089193/0020-fix-chroot-mountns-fp.patch
81 lp2091096/0021-fix-lxc-fp.patch
82+lp2085070/0022-ubuntu-avoid-restart-glusterd.patch
83+lp2089155/0023-ubuntu-avoid-restart-keepalived.patch

Subscribers

People subscribed via source and target branches