Merge ~r41k0u/ubuntu/+source/libtraceevent:fix-endian into ubuntu/+source/libtraceevent:ubuntu/devel

[Pragyansh Chaturvedi]

Set default file_bigendian in struct tep_handle

tep_alloc() creates a tep_handle object and sets the host_bigendian.
But it does not account for file_bigendian, which is set as TEP_LITTLE_ENDIAN
by default.
It is a safe assumption to set file_bigendian to the same value as
host_bigendian by default. If these are different, the user can set it using
event-parse-api
This fixes libtracefs on big-endian architectures, which depends on
libtraceevent. Without this fix, libtracefs would segfault on big-endian
architectures as host_bigendian would be set, but not file_bigendian.

[Pragyansh Chaturvedi (r41k0u)]

Hi adrien
Thank you for reviewing! I have addressed your comments and rebased the branch

[Sudip Mukherjee (sudipmuk)]

Thanks for the fix and also sending it upstream Pragyansh. I will add it to Debian today so it will just sync here in Ubuntu.

[Sudip Mukherjee (sudipmuk)]

I have uploaded to Debian now. Thanks for working on this.

[Andreas Hasenack (ahasenack)]

This got fixed in debian, and synced[1] into plucky already. Closing MP.

1. https://launchpad.net/ubuntu/+source/libtraceevent/1:1.8.4-2

diff --git a/debian/changelog b/debian/changelog
index 01bd474..fc57c5b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+libtraceevent (1:1.8.4-1ubuntu1) plucky; urgency=medium
+
+  * Set default file_bigendian in struct tep_handle
+    - d/p/0002-fix-file-endianness.patch: make file_bigendian the same
+      as host_bignendian in tep_alloc() (LP: #2062118)
+
+ -- Pragyansh Chaturvedi <[e-mail]>  Fri, 22 Nov 2024 13:32:27 +0530
+
 libtraceevent (1:1.8.4-1) unstable; urgency=medium
 
   * New upstream version 1.8.4
diff --git a/debian/control b/debian/control
index 52a68c3..6f592a9 100644
--- a/debian/control
+++ b/debian/control
@@ -1,6 +1,7 @@
 Source: libtraceevent
 Priority: optional
-Maintainer: Sudip Mukherjee <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Sudip Mukherjee <[e-mail]>
 Build-Depends: debhelper-compat (= 13), pkgconf, asciidoc,
                xmlto, source-highlight, libcunit1-dev
 Standards-Version: 4.7.0
diff --git a/debian/patches/0002-fix-file-endianness.patch b/debian/patches/0002-fix-file-endianness.patch
new file mode 100644
index 0000000..3471559
--- /dev/null
+++ b/debian/patches/0002-fix-file-endianness.patch
@@ -0,0 +1,31 @@
+Description: Set default file_bigendian in struct tep_handle
+ tep_alloc() creates a tep_handle object and sets the host_bigendian.
+ But it does not account for file_bigendian, which is set as TEP_LITTLE_ENDIAN
+ by default.
+ It is a safe assumption to set file_bigendian to the same value as
+ host_bigendian by default. If these are different, the user can set it using
+ event-parse-api
+ This fixes libtracefs on big-endian architectures, which depends on
+ libtraceevent. Without this fix, libtracefs would segfault on big-endian
+ architectures as host_bigendian would be set, but not file_bigendian.
+Author: Pragyansh Chaturvedi <[e-mail]>
+Bug: https://bugzilla.kernel.org/show_bug.cgi?id=219543
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libtracefs/+bug/2062118
+Forwarded: https://bugzilla.kernel.org/attachment.cgi?id=307303
+Last-Update: 2024-11-22
+---
+--- a/src/event-parse.c	2024-11-20 01:08:35.806823782 +0530
++++ b/src/event-parse.c	2024-11-22 13:13:50.775966911 +0530
+@@ -8501,6 +8501,12 @@
+ 	if (tep) {
+ 		tep->ref_count = 1;
+ 		tep->host_bigendian = tep_is_bigendian();
++
++		// We can make the following safe assumption
++		// for the default case. Else it leaves the
++		// file endianness as little endian and breaks
++		// things on big endian architectures.
++		tep->file_bigendian = tep->host_bigendian;
+ 	}
+ 
+ 	return tep;
diff --git a/debian/patches/series b/debian/patches/series
index fb0d2e7..909d94f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 0001-utest-autopkgtest.patch
+0002-fix-file-endianness.patch