Merge lp:~qzhang/lava-dispatcher/fix-886102 into lp:lava-dispatcher

Proposed by Spring Zhang
Status: Merged
Merged at revision: 154
Proposed branch: lp:~qzhang/lava-dispatcher/fix-886102
Merge into: lp:lava-dispatcher
Diff against target: 17 lines (+7/-0)
1 file modified
lava_dispatcher/actions/deploy.py (+7/-0)
To merge this branch: bzr merge lp:~qzhang/lava-dispatcher/fix-886102
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
Review via email: mp+81324@code.launchpad.net

Description of the change

include version in metadata

To post a comment you must log in.
Revision history for this message
Spring Zhang (qzhang) wrote :

Not tested yet, will report later.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Looks basically fine, but I'm quite jetlagged so don't take that too
seriously. I think the attribute name is a bit abbreviated --
'target.linaro-media-create-version' would be clearer I think!

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

it seems ok,
thanks

review: Approve
155. By Spring Zhang

modify metadata name

Revision history for this message
Spring Zhang (qzhang) wrote :

modified by comments, tested without error, but I can't find the bundle view in my local deployment lava-dashboard, so I can't verify if the metadata is updated.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_dispatcher/actions/deploy.py'
2--- lava_dispatcher/actions/deploy.py 2011-10-20 15:20:56 +0000
3+++ lava_dispatcher/actions/deploy.py 2011-11-08 05:35:26 +0000
4@@ -155,6 +155,13 @@
5 logging.info("Downloading the %s file" % rootfs_url)
6 rootfs_path = download(rootfs_url, tarball_dir)
7
8+ logging.info("linaro-media-create version information")
9+ cmd = "sudo linaro-media-create -v"
10+ rc, output = getstatusoutput(cmd)
11+ metadata = self.context.test_data.get_metadata()
12+ metadata['target.linaro-media-create-version'] = output
13+ self.context.test_data.add_metadata(metadata)
14+
15 image_file = os.path.join(tarball_dir, "lava.img")
16 #XXX Hack for removing startupfiles from snowball hwpacks
17 if client.device_type == "snowball_sd":

Subscribers

People subscribed via source and target branches