Merge lp:~qunengrong/ubuntu-calendar-app/trunk into lp:ubuntu-calendar-app

Proposed by Neo Nengrong Qu
Status: Merged
Merged at revision: 12
Proposed branch: lp:~qunengrong/ubuntu-calendar-app/trunk
Merge into: lp:ubuntu-calendar-app
Diff against target: 10 lines (+1/-1)
1 file modified
calendar.qmlproject (+1/-1)
To merge this branch: bzr merge lp:~qunengrong/ubuntu-calendar-app/trunk
Reviewer Review Type Date Requested Status
Frank Mertens (community) tested the new import paths with qtcreator Approve
Review via email: mp+155300@code.launchpad.net

Description of the change

added importPaths for i386;"/usr/lib/x86_64-linux-gnu/qt5/qml"
so we can test on a 32-bit host;

To post a comment you must log in.
Revision history for this message
Neo Nengrong Qu (qunengrong) wrote :

maybe the best way is to improve the .qmlproject file syntax, so we can add some conditional rule to set proper importPaths

Revision history for this message
Frank Mertens (frankencode) wrote :

I have verified, that the QtCreator complains about missing import paths (design view), if the path is missing for the current host architecture. For amd64 that won't help much, QtCreator crashes shortly thereafter anyway...

review: Approve (tested the new import paths with qtcreator)
Revision history for this message
Frank Mertens (frankencode) wrote :

@Nengrong: If QtCreator crashes for you all the time, too, try using it for code editing only. Although even for code editing it has currently severe bugs. For instance it is currently not striping whitespace correctly, which I remember worked some time ago. Maybe there is a flag to enable it somehow. Anyways, do you know that you can run the app just by issuing 'qmlscene calendar.qml' ?

Revision history for this message
Neo Nengrong Qu (qunengrong) wrote :

@frank,
currently i mainly use qtcreator to view code , and browse codes, but without proper import paths the qml imports the packages not found will be underlined with red color; so the call of external tool qmlscene shall fail; also can't follow some function in the qml file, becase the package was not found;

either add the correct path to importPaths or set it to the env $QML_IMPORT_PATH , everything goes fine; and each time for a test, i'd first view the qml file on my host laptop with qmlscene, and then test on my nexus4 with hotkey ctrl+F12;

thanks for your review and reply;

> @Nengrong: If QtCreator crashes for you all the time, too, try using it for
> code editing only. Although even for code editing it has currently severe
> bugs. For instance it is currently not striping whitespace correctly, which I
> remember worked some time ago. Maybe there is a flag to enable it somehow.
> Anyways, do you know that you can run the app just by issuing 'qmlscene
> calendar.qml' ?

11. By Frank Mertens

Merged the data-service branch manually.

12. By Frank Mertens

Make the i386 QtCreator underline less code with red markers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'calendar.qmlproject'
2--- calendar.qmlproject 2013-02-12 16:27:52 +0000
3+++ calendar.qmlproject 2013-03-25 17:42:37 +0000
4@@ -16,5 +16,5 @@
5 directory: "."
6 }
7 /* List of plugin directories passed to QML runtime */
8- importPaths: [ "." ,"/usr/lib/x86_64-linux-gnu/qt5/qml" ]
9+ importPaths: [ "." ,"/usr/lib/i386-linux-gnu/qt5/qml/", "/usr/lib/x86_64-linux-gnu/qt5/qml" ]
10 }

Subscribers

People subscribed via source and target branches

to status/vote changes: