Zim

Merge lp:~quietdragon/zim/fixes into lp:~jaap.karssenberg/zim/pyzim

  1. fixes
  2. Merge into pyzim
Proposed by Quiet Dragon
Status: Rejected
Rejected by: Jaap Karssenberg
Proposed branch: lp:~quietdragon/zim/fixes
Merge into: lp:~jaap.karssenberg/zim/pyzim
Diff against target: 12 lines (+1/-1)
1 file modified
zim/plugins/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~quietdragon/zim/fixes
Reviewer Review Type Date Requested Status
Jaap Karssenberg Pending
Review via email: mp+197276@code.launchpad.net

Description of the change

Apparent mis-spelling of data member name.

To post a comment you must log in.
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Thanks for the patch - highly appreciated to get the patch instead of a bug report. However will not merge - there is new code for this function in the lp:~jaap.karssenberg/zim/pyzim-refactor branch and this attribute should not appear anymore in the code.

Revision history for this message
Quiet Dragon (quietdragon) wrote :

Thanks for the quick feedback.

Unmerged revisions

675. By Quiet Dragon

Correct misspelling of self._is_image_generator_plugin.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'zim/plugins/__init__.py'
2--- zim/plugins/__init__.py 2013-03-23 15:40:21 +0000
3+++ zim/plugins/__init__.py 2013-11-30 02:06:47 +0000
4@@ -629,7 +629,7 @@
5 @todo: document image geneartor plugins
6 '''
7 self.ui.mainwindow.pageview.register_image_generator_plugin(self, type)
8- self._is_image_generator_pluging = True
9+ self._is_image_generator_plugin = True
10
11
12 # Need to register classes defining gobject signals