Code review comment for lp:~quequotion/slingshot/fix-1635776

Revision history for this message
quequotion (quequotion) wrote :

> Do you need the EventBox (with gala)?
Tried with patch reduced to only:
@@ -562,7 +549,7 @@
                     if (!search_entry.has_focus) {
                         search_entry.grab_focus ();
                         search_entry.move_cursor (Gtk.MovementStep.BUFFER_ENDS, 0, false);
- search_entry.key_press_event (event);
+ search_entry.im_context_filter_keypress (event);
                     }
                     return false;

(restored EventBox code)

This did not help. Although scrolling (still) works, the EventBox causes two problems: each input character is doubled and slingshot does not refresh view while typing in the search box (or possibly process input at all) until changing desktops (ergo, likely on full screen redraw).

I really think the EventBox is problematic.

« Back to merge proposal