Merge lp:~quam-plures-core/quam-plures/dataobject-set_param-integer-fix into lp:quam-plures

[Tilman Blumenbach]

[EdB (edb)]

Since you're way ahead of me with this smarts stuff all I can say on a quick look is "wow that's a pretty big comment block ya got there" ;)

I'll d/l the branch and do a localhost test then say okay or it failed, but wow I gotta go sit in a smelly room on a plastic chair for a few hours so the state will love me at this particular moment. Half a day or so, please.

[Tilman Blumenbach (tblue)]

Of course, take your time.

This is just a merge from b2evolution trunk.

[EdB (edb)]

Tested on localhost, can't find nothing wrong, so ... merge away!

review: Approve

=== modified file 'inc/_core/model/dataobjects/_dataobject.class.php'
--- inc/_core/model/dataobjects/_dataobject.class.php	2009-12-19 19:51:52 +0000
+++ inc/_core/model/dataobjects/_dataobject.class.php	2010-02-17 18:27:17 +0000
@@ -532,6 +532,34 @@
 		// i-e: transform 0 to ''
 		$new_value = ($make_null && ($parvalue === '')) ? NULL : $parvalue;
 
+		/* Tblue> Problem: All class member variables originating from the
+		 *                 DB are strings (unless they were NULL in the DB,
+		 *                 then they are set to NULL by the PHP MySQL
+		 *                 extension).
+		 *                 If we pass an integer or a double to this function,
+		 *                 the corresponding member variable gets changed
+		 *                 on every call, because its type is 'string' and
+		 *                 we compare using the === operator. Using the
+		 *                 == operator would be a bad idea, though, because
+		 *                 somebody could pass a NULL value to this function.
+		 *                 If the member variable then is set to 0, then
+		 *                 0 equals NULL and the member variable does not
+		 *                 get updated at all!
+		 *                 Thus, using the === operator is correct.
+		 *       Solution: If $fieldtype is 'number' and the type of the
+		 *                 passed value is either integer or double, we
+		 *                 convert it to a string (no data loss). The
+		 *                 member variable and the passed value can then
+		 *                 be correctly compared using the === operator.
+		 *  fp> It would be nicer to convert numeric values to ints & floats at load time in class constructor  x=(int)$y->value  or sth.
+		 * THIS IS EXPERIMENTAL! Feel free to revert if something does not
+		 * work as expected.
+		 */
+		if( $fieldtype == 'number' && ( is_int( $new_value ) || is_float( $new_value ) ) )
+		{
+			settype( $new_value, 'string' );
+		}
+
 /* >old
 		if( !isset($this->$parname) )
 		{	// This property has never been set before, set it to NULL now in order for tests to work:
@@ -563,8 +591,11 @@
 		{
 			// Set the value in the object:
 			// echo '<br/>'.$this->dbtablename.' object, setting param '.$parname.'/'.$dbfield.' to '.$new_value.(is_null($new_value)?' NULL':'').' (was:'.$this->$parname.(is_null($this->$parname)?' NULL':'').')';
+			$Debuglog->add( $this->dbtablename.' object, setting param '
+						   .$parname.'/'.$dbfield.' to '.var_export( $new_value, true )
+						   .' (old: '.( isset( $this->$parname ) ? var_export( $this->$parname, true ) : 'NULL' )
+						   .')', 'dataobjects' );
 			$this->$parname = $new_value;
-			$Debuglog->add( $this->dbtablename.' object, setting param '.$parname.'/'.$dbfield.' to '.$this->$parname, 'dataobjects' );
 
 			// Remember change for later db update:
 			$this->dbchange( $dbfield, $fieldtype, $parname );
@@ -656,4 +687,4 @@
 
 
 
-?>
\ No newline at end of file
+?>