Quam Plures

Merge lp:~quam-plures-core/quam-plures/credits_fix into lp:quam-plures

  1. credits_fix
  2. Merge into trunk
Proposed by Yabs
Status: Merged
Merged at revision: 7571
Proposed branch: lp:~quam-plures-core/quam-plures/credits_fix
Merge into: lp:quam-plures
Diff against target: 11 lines (+1/-0)
1 file modified
qp_inc/collections/model/_blog.class.php (+1/-0)
To merge this branch: bzr merge lp:~quam-plures-core/quam-plures/credits_fix
Reviewer Review Type Date Requested Status
EdB Approve
Lee Turner (community) Approve
Review via email: mp+41416@code.launchpad.net

Description of the change

Defines $credits_array before it's used

¥

To post a comment you must log in.
Revision history for this message
Lee Turner (leeturner) wrote :

Downloaded, tested and it does what it says on the tin

review: Approve
Revision history for this message
Yabs (yabs) wrote :

Yay for fried cpu's :-S

Thanks for the review/approve, I'll merge it in when I catch up with several days of downtime :(

¥

Revision history for this message
EdB (edb) wrote :

Looks good :)

review: Approve
Revision history for this message
EdB (edb) wrote :

I meant "works good", not that it looks bad or anything. Just that testing is all about working ya know? So "looks good, works great, saves the environment, kind to children, even PETA likes it" is how it is.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qp_inc/collections/model/_blog.class.php'
2--- qp_inc/collections/model/_blog.class.php 2010-10-18 00:55:39 +0000
3+++ qp_inc/collections/model/_blog.class.php 2010-11-21 16:18:57 +0000
4@@ -1475,6 +1475,7 @@
5
6 if( param( 'credits_page', 'string', NULL ) !== NULL )
7 { // credits page section:
8+ $credits_array = array();
9 $this->set_setting( 'credits_page', get_param( 'credits_page' ) );
10 if( param( 'template', 'integer' ) ) $credits_array[] = 'template';
11 if( param( 'plugins', 'integer' ) ) $credits_array[] = 'plugins';

Subscribers

People subscribed via source and target branches