Merge lp:~quam-plures-core/quam-plures/bug-525451 into lp:quam-plures

Proposed by Tilman Blumenbach
Status: Merged
Merged at revision: not available
Proposed branch: lp:~quam-plures-core/quam-plures/bug-525451
Merge into: lp:quam-plures
Diff against target: 72 lines (+11/-3)
3 files modified
inc/_core/__core.init.php (+5/-1)
rsc/css/basic.css (+5/-1)
templates/_toolbar.inc.php (+1/-1)
To merge this branch: bzr merge lp:~quam-plures-core/quam-plures/bug-525451
Reviewer Review Type Date Requested Status
EdB Approve
Review via email: mp+19823@code.launchpad.net
To post a comment you must log in.
Revision history for this message
EdB (edb) wrote :

Will get and test right now, but fer cryin out loud cosmetics are not bugs.

Anyway seems like a good time for multiple browser testing?

Revision history for this message
EdB (edb) wrote :

Cool! Saw the 'subtle shift' one on the navbar and checked in the 5 browsers I have - all good. Forgot to see what the debug one was all about, but yay!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'inc/_core/__core.init.php'
2--- inc/_core/__core.init.php 2010-02-21 05:04:49 +0000
3+++ inc/_core/__core.init.php 2010-02-21 20:19:13 +0000
4@@ -446,6 +446,7 @@
5 'href' => get_user_logout_url(),
6 );
7
8+ $icon_class = 'iconbtn';
9 if( $is_admin_page )
10 {
11 if( !empty( $Blog ) )
12@@ -453,6 +454,7 @@
13 $entries['abswitch'] = array(
14 'text' => T_('Blog').' '.get_icon('switch-to-blog'),
15 'href' => $Blog->get( 'url' ),
16+ 'class' => $icon_class,
17 );
18 }
19 else
20@@ -460,6 +462,7 @@
21 $entries['abswitch'] = array(
22 'text' => T_('Home').' '.get_icon('switch-to-blog'),
23 'href' => $home_url,
24+ 'class' => $icon_class,
25 );
26 }
27 }
28@@ -468,12 +471,13 @@
29 $entries['abswitch'] = array(
30 'text' => T_('Admin').' '.get_icon('switch-to-admin'),
31 'href' => $admin_url,
32+ 'class' => $icon_class,
33 );
34 }
35
36 $entries['logout'] = array(
37 'text' => T_('Logout').' '.get_icon('close'),
38- 'class' => 'rollover',
39+ 'class' => 'rollover '.$icon_class,
40 'href' => get_user_logout_url(),
41 );
42
43
44=== modified file 'rsc/css/basic.css'
45--- rsc/css/basic.css 2009-12-31 09:41:57 +0000
46+++ rsc/css/basic.css 2010-02-21 20:19:13 +0000
47@@ -197,7 +197,11 @@
48 color: ButtonText;
49 }
50 .sf-menu-right a {
51- padding: 3px 1ex 0px; /* .5em need to macth global height above */
52+ padding: 3px 1ex 3px; /* .5em need to macth global height above */
53+}
54+.sf-menu-right a.iconbtn {
55+ padding-top: 2px; /* assumes icon is 16px high. */
56+ padding-bottom: 0px;
57 }
58 .sf-menu a, .sf-menu a:visited { /* visited pseudo selector so IE6 applies text colour*/
59 color: ButtonText;
60
61=== modified file 'templates/_toolbar.inc.php'
62--- templates/_toolbar.inc.php 2010-01-22 21:33:56 +0000
63+++ templates/_toolbar.inc.php 2010-02-21 20:19:13 +0000
64@@ -75,7 +75,7 @@
65 echo $topleft_Menu->get_html_menu( NULL, 'sf-menu-left' );
66 if( $debug )
67 {
68- echo '<div style="position:absolute;left:80ex;top:2px;color:#999">'.$disp_detail.'</div>';
69+ echo '<div style="position:relative;left:5px;top:-8px;color:#999;z-index:-1;">'.$disp_detail.'</div>';
70 }
71 }
72 ?>

Subscribers

People subscribed via source and target branches