Merge lp:~qqworini/ubuntu-rssreader-app/optimize-grid-item into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Joey Chan
Status: Merged
Approved by: Roman Shchekin
Approved revision: 62
Merged at revision: 62
Proposed branch: lp:~qqworini/ubuntu-rssreader-app/optimize-grid-item
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 47 lines (+13/-4)
2 files modified
article_items/ArticleFullImg.qml (+6/-1)
article_items/ArticleOneImgA.qml (+7/-3)
To merge this branch: bzr merge lp:~qqworini/ubuntu-rssreader-app/optimize-grid-item
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+184431@code.launchpad.net

Commit message

optimize image performance in grid item

Description of the change

optimize image performance in grid item

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'article_items/ArticleFullImg.qml'
2--- article_items/ArticleFullImg.qml 2013-09-06 07:27:18 +0000
3+++ article_items/ArticleFullImg.qml 2013-09-07 11:29:39 +0000
4@@ -30,8 +30,13 @@
5 radius: "medium"
6 image: Image {
7 id: pic
8- width: u_pic.width
9+ width: {
10+ if (implicitHeight < 50 || implicitWidth < 50) return 0
11+ else return u_pic.width
12+ }
13+ height: width * implicitHeight / implicitWidth
14 source: imageArray[0]
15+ sourceSize.width: u_pic.width
16 }
17 }
18 }
19
20=== modified file 'article_items/ArticleOneImgA.qml'
21--- article_items/ArticleOneImgA.qml 2013-09-06 07:27:18 +0000
22+++ article_items/ArticleOneImgA.qml 2013-09-07 11:29:39 +0000
23@@ -31,9 +31,13 @@
24 radius: "medium"
25 image: Image {
26 id: pic
27- width: u_pic.width
28- fillMode: Image.PreserveAspectFit
29+ width: {
30+ if (implicitHeight < 50 || implicitWidth < 50) return 0
31+ else return u_pic.width
32+ }
33+ height: width * implicitHeight / implicitWidth
34 source: imageArray[0]
35+ sourceSize.width: u_pic.width
36 }
37 }
38
39@@ -93,7 +97,7 @@
40 if (dbResult.rowsAffected == 1) {
41 rss_item.status = "1"
42 }
43- mainView.toRssPage(rss_model, model_index) ;
44+ mainView.toRssPage(rss_model, model_index)
45 }
46 }
47 }

Subscribers

People subscribed via source and target branches