Merge lp:~qqworini/ubuntu-rssreader-app/fix-toolbar-bug into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Status: | Merged |
---|---|
Approved by: | Roman Shchekin |
Approved revision: | 72 |
Merged at revision: | 73 |
Proposed branch: | lp:~qqworini/ubuntu-rssreader-app/fix-toolbar-bug |
Merge into: | lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk |
Diff against target: |
45 lines (+8/-2) 2 files modified
feeds/AppendFeedPage.qml (+4/-1) feeds/ChooseTopicPage.qml (+4/-1) |
To merge this branch: | bzr merge lp:~qqworini/ubuntu-rssreader-app/fix-toolbar-bug |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+187976@code.launchpad.net |
Commit message
fix bug #1231137: Missing "Next" button while adding feed (desktop only)
Description of the change
fix bug #1231137: Missing "Next" button while adding feed (desktop only)
// code like below will produce this bug
Page{
tool: ToolbarItems { // ToolbarItems initial with the page
id: toolbar
opened: true // bug from here, never open in desktop
locked: true // if set lock to false, toolbar can be swiped up
// code like below solve temporarily
Page{
id: page
tool: null // set the tool to null at initialization
ToolbarItems {
id: toolbar
opened: true
locked: true
}
function setTool() {
page.tools = toolbar // set toolbar manually can solve
}
PASSED: Continuous integration, rev:72 91.189. 93.70:8080/ job/ubuntu- rssreader- app-ci/ 54/ 91.189. 93.70:8080/ job/generic- mediumtests/ 500 91.189. 93.70:8080/ job/ubuntu- rssreader- app-precise- amd64-ci/ 54 91.189. 93.70:8080/ job/ubuntu- rssreader- app-quantal- amd64-ci/ 54 91.189. 93.70:8080/ job/ubuntu- rssreader- app-raring- amd64-ci/ 54 91.189. 93.70:8080/ job/ubuntu- rssreader- app-saucy- amd64-ci/ 54
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- rssreader- app-ci/ 54/rebuild
http://