Merge lp:~qqworini/ubuntu-rssreader-app/fix-toolbar-bug-comment into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Joey Chan
Status: Merged
Approved by: David Planella
Approved revision: 73
Merged at revision: 75
Proposed branch: lp:~qqworini/ubuntu-rssreader-app/fix-toolbar-bug-comment
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 27 lines (+6/-0)
2 files modified
feeds/AppendFeedPage.qml (+3/-0)
feeds/ChooseTopicPage.qml (+3/-0)
To merge this branch: bzr merge lp:~qqworini/ubuntu-rssreader-app/fix-toolbar-bug-comment
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+187991@code.launchpad.net

Commit message

add workaround comment as David requested

Description of the change

add workaround comment as David requested

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Looks good to me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'feeds/AppendFeedPage.qml'
2--- feeds/AppendFeedPage.qml 2013-09-27 06:04:11 +0000
3+++ feeds/AppendFeedPage.qml 2013-09-27 08:31:20 +0000
4@@ -20,6 +20,9 @@
5 //.property var selectedFeeds: null // Become local.
6 property bool resultsReceived: false // Indicates that at least once results were received.
7
8+ // Workaround for bug #1231137
9+ // set the tools to null, then add the toolbar manually when enter this page
10+
11 tools: null
12
13 ToolbarItems {
14
15=== modified file 'feeds/ChooseTopicPage.qml'
16--- feeds/ChooseTopicPage.qml 2013-09-27 06:04:11 +0000
17+++ feeds/ChooseTopicPage.qml 2013-09-27 08:31:20 +0000
18@@ -17,6 +17,9 @@
19
20 signal topicChoosen(int topicId, var addedFeeds)
21
22+ // Workaround for bug #1231137
23+ // set the tools to null, then add the toolbar manually when enter this page
24+
25 tools: null
26
27 ToolbarItems {

Subscribers

People subscribed via source and target branches