Merge lp:~qqworini/ubuntu-rssreader-app/fix-bug-1335871-1335876 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Joey Chan
Status: Merged
Approved by: Roman Shchekin
Approved revision: 247
Merged at revision: 250
Proposed branch: lp:~qqworini/ubuntu-rssreader-app/fix-bug-1335871-1335876
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 23 lines (+2/-0)
2 files modified
ArticleViewItem.qml (+1/-0)
ShortsTab.qml (+1/-0)
To merge this branch: bzr merge lp:~qqworini/ubuntu-rssreader-app/fix-bug-1335871-1335876
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+225105@code.launchpad.net

Commit message

fix bug 1335871 & 1335876

Description of the change

fix bug 1335871 & 1335876

Roman said there's another "author" issue from autopilot test, but I can tell that's an error from U1DB, it did not store the latest setting data which cause the autopilot test failed.
So I suggest someone clear all data of Shorts (only needed this time, not every time)

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Trunk is now fixed and working properly. Kicking off a rebuild for this MP which should reflect any issues properly

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Joey Chan (qqworini) wrote :

lol

THX !

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ArticleViewItem.qml'
2--- ArticleViewItem.qml 2014-05-14 05:28:12 +0000
3+++ ArticleViewItem.qml 2014-07-01 03:45:26 +0000
4@@ -191,6 +191,7 @@
5 anchors.horizontalCenter: parent.horizontalCenter
6 width: parent.width - units.gu(4)
7 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
8+ visible: text !== "" && text !== '""'
9 }
10
11 Label {
12
13=== modified file 'ShortsTab.qml'
14--- ShortsTab.qml 2014-04-30 17:33:12 +0000
15+++ ShortsTab.qml 2014-07-01 03:45:26 +0000
16@@ -155,6 +155,7 @@
17 "title" : cart.title,
18 "content" : cart.content,
19 "link" : cart.link,
20+ "author": cart.author,
21 "description" : cart.description,
22 "pubdate" : cart.pubdate,
23 "status" : cart.status,

Subscribers

People subscribed via source and target branches