Merge lp:~qqworini/ubuntu-rssreader-app/article-saved-and-read into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Joey Chan
Status: Merged
Approved by: Roman Shchekin
Approved revision: 119
Merged at revision: 121
Proposed branch: lp:~qqworini/ubuntu-rssreader-app/article-saved-and-read
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 13 lines (+2/-1)
1 file modified
RssFeedPage.qml (+2/-1)
To merge this branch: bzr merge lp:~qqworini/ubuntu-rssreader-app/article-saved-and-read
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+191661@code.launchpad.net

Commit message

article will be treat as read when saved, this is a fall back workaround

Description of the change

article will be treat as read when saved, this is a fall back workaround

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Roman Shchekin (mrqtros) wrote :

I spend a lot of time to get it work :(

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'RssFeedPage.qml'
2--- RssFeedPage.qml 2013-10-15 11:47:40 +0000
3+++ RssFeedPage.qml 2013-10-17 15:04:24 +0000
4@@ -82,7 +82,8 @@
5 //rssItem.favourite = fav
6 var dbResult1 = DB.updateArticleStatus(rssItem.id, "0")
7 if (dbResult1.rowsAffected == 1) {
8- articleStatusChanged(rssItem.tagId, rssItem.id, "0" /*rssItem.status*/ )
9+ // comment bellow to disable status signal, all articles will be set as read
10+ //articleStatusChanged(rssItem.tagId, rssItem.id, "0" /*rssItem.status*/ )
11 }
12
13 articleFavouriteChanged(rssItem, fav)

Subscribers

People subscribed via source and target branches