Merge lp:~qcumber-some/widelands/alocritani-896879-change_button_enable_logic into lp:widelands
Proposed by
Jens Beyer
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 6132 | ||||
Proposed branch: | lp:~qcumber-some/widelands/alocritani-896879-change_button_enable_logic | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
24 lines (+6/-2) 1 file modified
src/ui_basic/spinbox.cc (+6/-2) |
||||
To merge this branch: | bzr merge lp:~qcumber-some/widelands/alocritani-896879-change_button_enable_logic | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nicolai Hähnle | Approve | ||
Tino | Approve | ||
Review via email: mp+83533@code.launchpad.net |
Description of the change
On behalf of alocritani (see bug comments).
To post a comment you must log in.
Approve.
Side note: I'm not a huge fan of the type of alignment that is done in the hunk at line 172. Yes, the original code does it that way, so this is not a comment against the patch. I just don't think it's good practice, because it makes code maintenance more painful.