Merge lp:~pyflakes-dev/pyflakes/1108904-augmented-assignment into lp:pyflakes

Proposed by Florent
Status: Merged
Merged at revision: 67
Proposed branch: lp:~pyflakes-dev/pyflakes/1108904-augmented-assignment
Merge into: lp:pyflakes
Diff against target: 41 lines (+19/-1)
2 files modified
pyflakes/checker.py (+1/-1)
pyflakes/test/test_undefined_names.py (+18/-0)
To merge this branch: bzr merge lp:~pyflakes-dev/pyflakes/1108904-augmented-assignment
Reviewer Review Type Date Requested Status
Pyflakes Dev Pending
Review via email: mp+145391@code.launchpad.net

Description of the change

Fix for augmented assignments

To post a comment you must log in.
68. By Florent

More tests with augmented assignments.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'pyflakes/checker.py'
2--- pyflakes/checker.py 2013-01-29 08:10:46 +0000
3+++ pyflakes/checker.py 2013-01-29 15:37:21 +0000
4@@ -688,7 +688,7 @@
5 def AUGASSIGN(self, node):
6 self.handleNodeLoad(node.target)
7 self.handleNode(node.value, node)
8- self.handleNodeStore(node.target)
9+ self.handleNode(node.target, node)
10
11 def IMPORT(self, node):
12 for alias in node.names:
13
14=== modified file 'pyflakes/test/test_undefined_names.py'
15--- pyflakes/test/test_undefined_names.py 2013-01-28 23:35:39 +0000
16+++ pyflakes/test/test_undefined_names.py 2013-01-29 15:37:21 +0000
17@@ -220,6 +220,24 @@
18 return a
19 ''', m.UndefinedLocal)
20
21+ def test_undefinedAugmentedAssignment(self):
22+ self.flakes(
23+ '''
24+ def f(seq):
25+ a = 0
26+ seq[a] += 1
27+ seq[b] /= 2
28+ c[0] *= 2
29+ a -= 3
30+ d += 4
31+ e[any] = 5
32+ ''',
33+ m.UndefinedName, # b
34+ m.UndefinedName, # c
35+ m.UndefinedName, m.UnusedVariable, # d
36+ m.UndefinedName, # e
37+ )
38+
39 def test_nestedClass(self):
40 '''nested classes can access enclosing scope'''
41 self.flakes('''

Subscribers

People subscribed via source and target branches

to all changes: