Merge lp:~pwlars/utah/utah.dialout-group-again into lp:utah

Proposed by Paul Larson
Status: Work in progress
Proposed branch: lp:~pwlars/utah/utah.dialout-group-again
Merge into: lp:utah
Diff against target: 22 lines (+5/-3)
1 file modified
templates/utah-setup.jinja2 (+5/-3)
To merge this branch: bzr merge lp:~pwlars/utah/utah.dialout-group-again
Reviewer Review Type Date Requested Status
Canonical CI Engineering Pending
Review via email: mp+261058@code.launchpad.net

Commit message

Yet another place where we need to be really sure that syslog is in dialout group, or things go very badly. Also support both upstart and systemd service restart methods

Description of the change

After a bit of pain trying to get utah to tell me where it was failing today with the wily images, I narrowed it down to somewhere in this region of code. At first I thought it was surely the fact that we were using restart rather than systemctl restart, but that didn't fix it completely. For some reason, it seems like we're still not getting the syslog user into the dialout groups yet when it tries to start here. I've cowboyed this onto aldebaran for now, but I wanted to go ahead and land it too, just in case.

Unfortunately, I do still see random failures even with this patch, but it does seem to be doing better at least.

To post a comment you must log in.
1065. By Paul Larson

use service restart

Revision history for this message
Para Siva (psivaa) wrote :

No approved revision specified.

Revision history for this message
Para Siva (psivaa) wrote :

No approved revision specified.

Revision history for this message
Para Siva (psivaa) wrote :

No approved revision specified.

Unmerged revisions

1065. By Paul Larson

use service restart

1064. By Paul Larson

Yet another place where we need to be really sure that syslog is in dialout group, or things go very badly. Also support both upstart and systemd service restart methods

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/utah-setup.jinja2'
2--- templates/utah-setup.jinja2 2013-05-22 16:56:32 +0000
3+++ templates/utah-setup.jinja2 2015-06-04 11:57:57 +0000
4@@ -18,13 +18,15 @@
5 sleep 2
6 gw=\`ip route | grep default\`
7 done
8+EOF
9
10 # rsyslog may start skipping remote logging if it got too many
11 # messages to send before the network was up. This makes it
12 # start afresh and deliver our messages.
13- restart rsyslog
14- sleep 1
15-EOF
16+ adduser syslog dialout
17+ # We need to support both upstart and systemd restart methods
18+ service rsyslog restart rsyslog
19+ sleep 10
20 }
21
22 install_package() {

Subscribers

People subscribed via source and target branches