Merge lp:~pwlars/utah/from-host-unique-dir into lp:utah

[Paul Larson]

When we tried to run tests with FROM_HOST turned on for the phone testing, we saw that sometimes directories appeared to be missing at random. It looks like when utah is copying those testsuites to /var/lib/utah/testssuites and cleaning them up, it's all going to the same place. So the testsuites are getting yanked out from under running tests at some points.

This sets up a temporary directory to point utah to as the testdir. After some digging, I noticed that the statefile for utah still all happens in /var/lib/utah. I didn't see any problems with this since we don't reboot the host during tests, and we never saw any errors about the statefile, just the testsuite dirs being missing midway through the tests. Tested this locally with a phablet test run and the tmpdir does happen in /tmp/[generated] for each run

[Max Brustkern (nuclearbob)]

We may want to implement a deeper solution at some point, but we've already discussed how difficult that will be. I think this looks good for now.

review: Approve

[Andy Doan (doanac)]

review: Approve

=== modified file 'examples/run_utah_phablet.py'
--- examples/run_utah_phablet.py	2013-09-03 17:03:45 +0000
+++ examples/run_utah_phablet.py	2013-09-17 17:21:27 +0000
@@ -20,9 +20,11 @@
 
 import argparse
 import os
+import shutil
 import socket
 import subprocess
 import sys
+import tempfile
 import threading
 import time
 
@@ -271,10 +273,12 @@
     device.run_ubuntu('mkdir {}'.format(CLIENT_PROBES_DIR))
 
     host = os.path.join(args.results_dir, 'utah-host.yml')
-    cmd = '{} -d -o {} -r {} -p {}'.format(
-        args.utah_cmd, host, args.runlist, args.results_dir)
+    tmpdir = tempfile.mkdtemp()
+    cmd = '{} -d -o {} -r {} -p {} -t {}'.format(
+        args.utah_cmd, host, args.runlist, args.results_dir, tmpdir)
     rc = subprocess.call(cmd, env=env, shell=True)
     print('utah runlist exited with rc={}'.format(rc))
+    shutil.rmtree(tmpdir)
 
     # We've run the test, now do a run on the target so we can grab its YAML
     # and combine the proper parts of it with our results