Merge lp:~pwlars/ubuntu-touch-boottest/retry-error-12 into lp:ubuntu-touch-boottest

Proposed by Paul Larson
Status: Merged
Approved by: Francis Ginther
Approved revision: 5
Merged at revision: 4
Proposed branch: lp:~pwlars/ubuntu-touch-boottest/retry-error-12
Merge into: lp:ubuntu-touch-boottest
Diff against target: 14 lines (+3/-1)
1 file modified
run-adt.py (+3/-1)
To merge this branch: bzr merge lp:~pwlars/ubuntu-touch-boottest/retry-error-12
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Paul Larson Needs Resubmitting
Review via email: mp+261278@code.launchpad.net

Commit message

Retry on error 12 for now also

Description of the change

Retry on error 12 for now also

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Can you add a comment on why we need to add error 12 here?

review: Needs Fixing
Revision history for this message
Paul Larson (pwlars) wrote :

how's that?

review: Needs Resubmitting
5. By Paul Larson

Add a comment about why we are retrying on error 12

Revision history for this message
Francis Ginther (fginther) wrote :

This is a good first step. We may need to refine this to only retry if it also detects 255 errors in the log.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run-adt.py'
2--- run-adt.py 2015-06-04 18:46:39 +0000
3+++ run-adt.py 2015-06-05 20:45:13 +0000
4@@ -15,7 +15,9 @@
5 MAX_RUN_COUNT = 3
6
7 # adt-run exit codes we should re-run the adt-run call on:
8-RETRY_CODES = (16, 20)
9+# XXX plars: error 12 should be removed once it's properly detected as
10+# an ssh failure from adt-run
11+RETRY_CODES = (12, 16, 20)
12
13
14 def main():

Subscribers

People subscribed via source and target branches