Merge lp:~pwlars/ubuntu-ci-services-itself/check-testbed into lp:ubuntu-ci-services-itself

[Paul Larson]

Make sure test_bed exists before tearing it down to avoid extraneous errors if we hit other problems

Small fix for the testrunner. I was seeing a failure due to keystoneclient being missing. Installing keystoneclient, I can now get through a full test run. That part of it looks like it will be taken care of ev's recent changes to put things in our ppa, as testrunner installs packages that properly depend on keystoneclient now. This wasn't obvious at first though because test_bed didn't get to the point of getting created so couldn't see the earlier error.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:292
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/254/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/254/rebuild

review: Approve (continuous-integration)

[Vincent Ladeuil (vila)]

+1 from me, clearly the try/finally block is too big.

review: Approve

[Vincent Ladeuil (vila)]

> Installing keystoneclient, I can now get through a full test run.

Can you elaborate on that ? Is it as a full end-to-end test or some other more direct manual test ?

> This wasn't obvious at first though because test_bed didn't get to the point of getting created so couldn't see the earlier error.

Definitely worth fixing asap, it's on my radar.

review: Needs Information

[Paul Larson (pwlars)]

It was a full end-to-end test run. I created a ticket with the cli, and watched it build the package, build the image, run the tests, etc

[Vincent Ladeuil (vila)]

I hereby DO approve this MP !

review: Approve

[Chris Johnston (cjohnston)]

The attempt to merge lp:~pwlars/ubuntu-ci-services-itself/check-testbed into lp:ubuntu-ci-services-itself failed. Below is the output from the failed tests.

New python executable in /tmp/tmp.XJFeI8tBGq/bin/python
Installing distribute.............................................................................................................................................................................................done.
Installing pip...............done.
== Testing ci-utils ....
Unpacking /tmp/tarmac/branch.MnwhH1/.deps/Babel-1.3.tar.gz
  Running setup.py egg_info for package from file:///tmp/tarmac/branch.MnwhH1/.deps/Babel-1.3.tar.gz

    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
Installing collected packages: Babel
  Running setup.py install for Babel

    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
    Installing pybabel script to /tmp/tmp.XJFeI8tBGq/bin
Successfully installed Babel
Cleaning up...
Using saved parent location: bzr+ssh://bazaar.launchpad.net/~canonical-ci-engineering/ubuntu-ci-services-itself/deps/
No revisions or tags to pull.
Unpacking /tmp/tarmac/branch.MnwhH1/.deps/pbr-0.6.tar.gz
  Running setup.py egg_info for package from file:///tmp/tarmac/branch.MnwhH1/.deps/pbr-0.6.tar.gz
    [pbr] Processing SOURCES.txt
    warning: LocalManifestMaker: standard file '-c' not found

    warning: no previously-included files found matching '.gitignore'
    warning: no previously-included files found matching '.gitreview'
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    warning: no previously-included files found matching '.gitignore'
    warning: no previously-included files found matching '.gitreview'
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
Installing collected packages: pbr
  Running setup.py install for pbr
    [pbr] Reusing existing SOURCES.txt
Successfully installed pbr
Cleaning up...
Using saved parent location: bzr+ssh://bazaar.launchpad.net/~canonical-ci-engineering/ubuntu-ci-services-itself/deps/
No revisions or tags to pull.
Unpacking /tmp/tarmac/branch.MnwhH1/.deps/iso8601-0.1.8.tar.gz
  Running setup.py egg_info for package from file:///tmp/tarmac/branch.MnwhH1/.deps/iso8601-0.1.8.tar.gz

Installing collected packages: iso8601
  Running setup.py install for iso8601

Successfully installed iso8601
Cleaning up...
Using saved parent location: bzr+ssh://bazaar.launchpad.net/~canonical-ci-engineering/ubuntu-ci-services-itself/deps/
No revisions or tags to pull.
Unpacking /tmp/tarmac/branch.MnwhH1/.deps/prettytable-0.7.2.zip
  Running setup.py egg_info for package from file:///tmp/tarmac/branch.MnwhH1/.deps/prettytable-0.7.2.zip

Installing collected packages: prettyta...

=== modified file 'test_runner/run_worker'
--- test_runner/run_worker	2014-02-24 19:42:48 +0000
+++ test_runner/run_worker	2014-02-28 19:52:07 +0000
@@ -49,6 +49,7 @@
     notify = amqp_utils.progress_completed
     results = {}
     try:
+        test_bed = None
         store = data_store.create_for_ticket(ticket, tstrun.get_auth_config())
         # FIXME: We need either a config option or a parameter for the instance
         # flavor -- vila 2014-01-29
@@ -88,7 +89,8 @@
         # an exception occurs while calling 'notify' just above, tricky testing
         # ahead... -- vila 2014-02-06
         msg.channel.basic_ack(msg.delivery_tag)
-        test_bed.teardown()
+        if test_bed:
+            test_bed.teardown()
 
 
 if __name__ == '__main__':