Merge ~pwlars/snappy-hwe-snaps/+git/jenkins-jobs:sudo-debconf-set-selections into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

Proposed by Paul Larson
Status: Merged
Approved by: Simon Fels
Approved revision: cc461799fd4a833d21fc3e2688df415766d5f01b
Merged at revision: 36523ef4dfd216a404563bc0862e47499b82757d
Proposed branch: ~pwlars/snappy-hwe-snaps/+git/jenkins-jobs:sudo-debconf-set-selections
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 15 lines (+2/-2)
1 file modified
jobs/infrastructure/prepare-0-install.sh (+2/-2)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Jim Hodapp (community) Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+328683@code.launchpad.net

Description of the change

oops, sudo needed. This works, for the package install, but I did notice that it seems to fail on the pip stuff later - http_proxy is likely needed for that

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) :
review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/infrastructure/prepare-0-install.sh b/jobs/infrastructure/prepare-0-install.sh
2index a41e811..1ec2212 100644
3--- a/jobs/infrastructure/prepare-0-install.sh
4+++ b/jobs/infrastructure/prepare-0-install.sh
5@@ -23,8 +23,8 @@ sudo add-apt-repository --yes ppa:snappy-hwe-team/ci-tools
6
7 sudo apt-get update
8
9-echo "postfix postfix/mailname string $(hostname)" | debconf-set-selections
10-echo "postfix postfix/main_mailer_type string 'Internet Site'" | debconf-set-selections
11+echo "postfix postfix/mailname string $(hostname)" | sudo debconf-set-selections
12+echo "postfix postfix/main_mailer_type string 'Internet Site'" | sudo debconf-set-selections
13
14 sudo apt-get install --yes \
15 git \

Subscribers

People subscribed via source and target branches

to all changes: