Merge ~pwlars/snappy-hwe-snaps/+git/jenkins-jobs:debconf-selections-fix into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

Proposed by Paul Larson
Status: Merged
Approved by: Simon Fels
Approved revision: 2abb3497944d376e95b30994c55e730a03c63d4b
Merged at revision: ea3711d859b6ccb02ee36c5600296a69428de03d
Proposed branch: ~pwlars/snappy-hwe-snaps/+git/jenkins-jobs:debconf-selections-fix
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 15 lines (+2/-2)
1 file modified
jobs/infrastructure/prepare-0-install.sh (+2/-2)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+328664@code.launchpad.net

Description of the change

the prepare.sh script uses dash, not bash. This should fix the error when setting up debconf selections for postfix

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM, tested in my local jenkins setup.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/infrastructure/prepare-0-install.sh b/jobs/infrastructure/prepare-0-install.sh
2index 7dc2379..a41e811 100644
3--- a/jobs/infrastructure/prepare-0-install.sh
4+++ b/jobs/infrastructure/prepare-0-install.sh
5@@ -23,8 +23,8 @@ sudo add-apt-repository --yes ppa:snappy-hwe-team/ci-tools
6
7 sudo apt-get update
8
9-debconf-set-selections <<< "postfix postfix/mailname string $(hostname)"
10-debconf-set-selections <<< "postfix postfix/main_mailer_type string 'Internet Site'"
11+echo "postfix postfix/mailname string $(hostname)" | debconf-set-selections
12+echo "postfix postfix/main_mailer_type string 'Internet Site'" | debconf-set-selections
13
14 sudo apt-get install --yes \
15 git \

Subscribers

People subscribed via source and target branches

to all changes: