Merge ~pwlars/revcache/+git/revcache-charm:fix-config-defaults into ~canonical-hw-cert/revcache/+git/revcache-charm:master
Proposed by
Paul Larson
Status: | Merged |
---|---|
Approved by: | Paul Larson |
Approved revision: | fd9ad1c3f3a3c8d27749bf86a4f777b2d98d9ad5 |
Merged at revision: | 8855a325653ee13dcff47f5e49ef05fba43c256e |
Proposed branch: | ~pwlars/revcache/+git/revcache-charm:fix-config-defaults |
Merge into: | ~canonical-hw-cert/revcache/+git/revcache-charm:master |
Diff against target: |
30 lines (+3/-2) 2 files modified
config.yaml (+2/-2) playbooks/revcache.yaml (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Larson | Approve | ||
Review via email:
|
Description of the change
Fixes some bad defaults (which are easy to work around, but better to have the right defaults). Also, I think that having the config file written at config-changed time *might* be better. It's hard to test, because even at relation-changed time, it's kind of bad right now. Juju doesn't always fill in the variables the way it's supposed to.
To post a comment you must log in.
I'm iterating on these minor fixes right now, would like to go ahead and land/deploy this