Merge ~pwlars/revcache/+git/revcache-charm:juju1-support into ~canonical-hw-cert/revcache/+git/revcache-charm:master
Proposed by
Paul Larson
Status: | Merged |
---|---|
Approved by: | Paul Larson |
Approved revision: | fff4d98edf52afaf94ff3d9b66d765ef667e2535 |
Merged at revision: | 7cd5a3bbeda700aad6f99c58bfa2e1b8512920e9 |
Proposed branch: | ~pwlars/revcache/+git/revcache-charm:juju1-support |
Merge into: | ~canonical-hw-cert/revcache/+git/revcache-charm:master |
Diff against target: |
72 lines (+35/-4) 2 files modified
config.yaml (+12/-0) playbooks/revcache.yaml (+23/-4) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Larson | Approve | ||
Review via email:
|
This proposal supersedes a proposal from 2018-06-18.
Description of the change
I think this finally does what I want. I've tested it locally with some fake keys, and confirmed that it puts the files in the right location and uses the correct vhost template with ssl support for nginx *only* when specifying the certificates and ssl key in either the config or in an artifact. This allows us to support both juju1 and juju2 in the same charm!
To post a comment you must log in.
Wrong target, that should look a little more sane now :)