Merge ~pwlars/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:add-kernel-headers into ~checkbox-dev/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:master

Proposed by Paul Larson
Status: Rejected
Rejected by: Paul Larson
Proposed branch: ~pwlars/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:add-kernel-headers
Merge into: ~checkbox-dev/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:master
Diff against target: 9 lines (+1/-0)
1 file modified
snapcraft.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Paul Larson Disapprove
Review via email: mp+304037@code.launchpad.net

Description of the change

one-liner, that I *think* should fix the build problem with kernel headers missing, but I'm having trouble sorting out how to test it locally. I think it's certainly safe since it just adds a single package at build time, but I'm not sure yet whether it will be effective. In particular, there's some concern about the fact that building the snap in launchpad seems to happen on trusty, but we would be running it on a xenial system.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Um, sorry for not noticing that MR earlier, I did the exact same fix here:
https://code.launchpad.net/~kissiel/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts/+merge/304056

And we've merged it already.

Revision history for this message
Paul Larson (pwlars) wrote :

NP, as long as it's fixed, I don't care who's we land. :)
Yeah, I was a little confused when I saw your MP this morning, it made me wonder if I forgot to submit this yesterday or something went wrong in lp.

review: Disapprove

Unmerged commits

c6e41aa... by Paul Larson

add linux-headers-generic to build-packages

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 58d6e19..80ee672 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -24,3 +24,4 @@ parts:
6 - stress-ng
7 build-packages:
8 - gcc-multilib
9+ - linux-headers-generic

Subscribers

People subscribed via source and target branches