Merge ~pwlars/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:add-kernel-headers into ~checkbox-dev/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:master
Proposed by
Paul Larson
Status: | Rejected |
---|---|
Rejected by: | Paul Larson |
Proposed branch: | ~pwlars/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:add-kernel-headers |
Merge into: | ~checkbox-dev/plainbox-provider-snappy/+git/plainbox-provider-snappy-parts:master |
Diff against target: |
9 lines (+1/-0) 1 file modified
snapcraft.yaml (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Larson | Disapprove | ||
Review via email: mp+304037@code.launchpad.net |
Description of the change
one-liner, that I *think* should fix the build problem with kernel headers missing, but I'm having trouble sorting out how to test it locally. I think it's certainly safe since it just adds a single package at build time, but I'm not sure yet whether it will be effective. In particular, there's some concern about the fact that building the snap in launchpad seems to happen on trusty, but we would be running it on a xenial system.
To post a comment you must log in.
Um, sorry for not noticing that MR earlier, I did the exact same fix here: /code.launchpad .net/~kissiel/ plainbox- provider- snappy/ +git/plainbox- provider- snappy- parts/+ merge/304056
https:/
And we've merged it already.