Merge lp:~pwlars/lava-test/generate-bundle into lp:lava-test/0.0

[Paul Larson]

This is a stepping stone to adding a put subcommand to push results to the dashboard directly. But I think Zygmunt wanted a command to just produce bundles, and I think it's useful for debugging at the very least.

[James Westby (james-w)]

Hi,

40 + resultdir = os.path.join(config.resultsdir,result)

Space after the comma please.

146 + make_stream_result(self.config)
147 + cmd.main(argv=['stream000'])

Please have make_stream_result return the "stream000" value, magic
strings are bad.

Having e.g. analyzer_assigned_uuid repeated isn't great either, but
that's trickier to fix.

149 + self.assertEqual(expected_dict, returned_dict)
150 +
151 +def make_stream_result(config):

Two blank lines please.

Thanks,

James

review: Approve

[lp:~pwlars/lava-test/generate-bundle]

38. By Paul Larson on 2010-09-28

Fix up some formatting errors in _savetestdata

[Paul Larson (pwlars)]

On Mon, 2010-09-27 at 23:52 +0000, James Westby wrote:
> Please have make_stream_result return the "stream000" value, magic
> strings are bad.
>
> Having e.g. analyzer_assigned_uuid repeated isn't great either, but
> that's trickier to fix.
So I was able to work around this as well by having it assign a uuid and
return that along with the test id.
Thanks,
Paul Larson

[lp:~pwlars/lava-test/generate-bundle]

39. By Paul Larson on 2010-09-28

some minor cleanups

40. By Paul Larson on 2010-09-28

have make_stream_result return the test id and uuid that were assigned
so that the test can use them for comparison