Merge lp:~pwlars/core-image-publisher/fix-logger into lp:core-image-publisher

Proposed by Paul Larson
Status: Superseded
Proposed branch: lp:~pwlars/core-image-publisher/fix-logger
Merge into: lp:core-image-publisher
Diff against target: 33 lines (+5/-3)
1 file modified
core_image_publisher/worker.py (+5/-3)
To merge this branch: bzr merge lp:~pwlars/core-image-publisher/fix-logger
Reviewer Review Type Date Requested Status
Canonical CI Engineering Pending
Review via email: mp+254337@code.launchpad.net

This proposal has been superseded by a proposal from 2015-03-27.

Commit message

logging fixes

Description of the change

Some fixes for logging

To post a comment you must log in.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'core_image_publisher/worker.py'
2--- core_image_publisher/worker.py 2015-03-26 22:26:21 +0000
3+++ core_image_publisher/worker.py 2015-03-27 02:09:11 +0000
4@@ -17,8 +17,11 @@
5
6 """Business logic or the service lives here."""
7
8+import logging
9 from core_image_publisher.queue import enqueue_message
10
11+logger = logging.getLogger(__name__)
12+
13
14 def logging_worker(message):
15 logger.info("Got %r", message.payload, extra=message.payload)
16@@ -27,10 +30,10 @@
17 image_name = payload['image_name']
18 channel = payload['channel']
19 device = payload['device']
20- except KeyError as e:
21+ except KeyError:
22 logger.error(
23 "Unable to deserialize message payload - rejecting message: %s",
24- s,
25+ payload,
26 extra=payload
27 )
28 message.reject()
29@@ -55,4 +58,3 @@
30
31 def upload_image_to_glance(nova_image_path):
32 """Upload the nova image to glance, returning the name of the image in glance."""
33-

Subscribers

People subscribed via source and target branches