Merge lp:~pwlars/checkbox/checkbox.webcamtest into lp:checkbox

Proposed by Paul Larson
Status: Rejected
Rejected by: Daniel Manrique
Proposed branch: lp:~pwlars/checkbox/checkbox.webcamtest
Merge into: lp:checkbox
Diff against target: None lines
To merge this branch: bzr merge lp:~pwlars/checkbox/checkbox.webcamtest
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Disapprove
Review via email: mp+5663@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Simple test using gst_pipline_test for webcams

Revision history for this message
Daniel Manrique (roadmr) wrote :

Hi Paul,

Thanks so much for your contribution to checkbox. I also offer you my sincerest apologies for the time it took us to review this submission. Unfortunately, since the time you sent this merge request, a suite of several camera-related tests were developed for other purposes and added to checkbox, and will be included in checkbox 0.12 to ship with Ubuntu 11.10 in a few months. Thus, since the functionality you suggest is already implemented in the development version, I will mark this branch as disapproved, just to signify that it will not be included in checkbox.

If you like, you can branch the latest checkbox source code and see if you can suggest some improvements to our tests. We are doing our best to review contributions in a timely manner.

Thanks again!

- Daniel

review: Disapprove

Unmerged revisions

523. By Paul Larson

Added a new test to test webcam functionality

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'suites/manual.txt.in'
2--- suites/manual.txt.in 2009-04-06 16:50:09 +0000
3+++ suites/manual.txt.in 2009-04-17 04:16:37 +0000
4@@ -11,6 +11,18 @@
5 .
6 Do you hear a sound?
7
8+name: webcam
9+plugin: manual
10+categories:
11+ laptop
12+ desktop
13+requires: info.subsystem == 'video4linux'
14+command: gst_pipeline_test -t 10 'v4l2src ! autovideosink'
15+_description:
16+ Click the Test button to display the output from your webcam.
17+ .
18+ Did you see output from your camera?
19+
20 name: resolution
21 plugin: manual
22 categories:

Subscribers

People subscribed via source and target branches