Merge ~pwlars/checkbox-support/+git/packaging:add-python3-bluez into ~checkbox-dev/checkbox-support/+git/packaging:master

Proposed by Paul Larson
Status: Merged
Approved by: Paul Larson
Approved revision: aabe0163df0fe468115d427194944b50ca169251
Merged at revision: 88725ab0f58861438477acf88e39647e8d032d6f
Proposed branch: ~pwlars/checkbox-support/+git/packaging:add-python3-bluez
Merge into: ~checkbox-dev/checkbox-support/+git/packaging:master
Diff against target: 20 lines (+2/-0)
1 file modified
debian/control (+2/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Maciej Kisielewski Approve
Review via email: mp+402527@code.launchpad.net

Description of the change

This adds the pybluez dependency needed for the new eddystone test.
NB: For this to build on bionic, it needs a backport of python3-bluez (pybluez source package) in the ppa! The version in bionic originally only had python-bluez, not the python3 version, which we obviously need.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Makes sense, +1.

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Could you also patch https://code.launchpad.net/checkbox-core-snap or if done already share the links in this MR please?

For the checkbox snap, so you recommend to pin a particular version?

Which version do you want to backport in the ppa(s)? focal I guess.

review: Needs Information
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Since ppa(s) now contain pybluez for bionic, this MR can land.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/control b/debian/control
2index 71df7f0..d271663 100644
3--- a/debian/control
4+++ b/debian/control
5@@ -9,6 +9,7 @@ Build-Depends:
6 debhelper (>= 9),
7 dh-python,
8 python3-all,
9+ python3-bluez,
10 python3-dbus,
11 python3-distro,
12 python3-gi,
13@@ -29,6 +30,7 @@ Homepage: https://launchpad.net/checkbox-support
14 Package: python3-checkbox-support
15 Architecture: all
16 Depends: gir1.2-gudev-1.0,
17+ python3-bluez,
18 python3-dbus,
19 python3-distro,
20 python3-gi,

Subscribers

People subscribed via source and target branches