Merge ~pwlars/checkbox-support:more-reliable-eddystone into checkbox-support:master

Proposed by Paul Larson
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 3a3654ff4015e6413d53569235c9767e88748a3a
Merged at revision: a7ab96f56d8cab840b330826b063df5e3f731d06
Proposed branch: ~pwlars/checkbox-support:more-reliable-eddystone
Merge into: checkbox-support:master
Diff against target: 13 lines (+1/-1)
1 file modified
checkbox_support/scripts/eddystone_scanner.py (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+381680@code.launchpad.net

Description of the change

I noticed that the eddystone-scanner test is really unreliable (especially on slower devices like rpi3a+) but when I ssh to the device and try running it manually, it works fine. I played around with the timeout for turning bluetooth power on and I don't think we are waiting long enough. After increasing this, it worked every time for me (even rebooting in between), where it was never working on the first attempt before.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/checkbox_support/scripts/eddystone_scanner.py b/checkbox_support/scripts/eddystone_scanner.py
2index c67626e..ca36cab 100644
3--- a/checkbox_support/scripts/eddystone_scanner.py
4+++ b/checkbox_support/scripts/eddystone_scanner.py
5@@ -68,7 +68,7 @@ def main():
6 return 1
7 with InteractiveCommand('bluetoothctl') as btctl:
8 btctl.writeline('power on')
9- time.sleep(1)
10+ time.sleep(3)
11 btctl.writeline('exit')
12 btctl.kill()
13 event_loop = asyncio.get_event_loop()

Subscribers

People subscribed via source and target branches