Merge ~pwlars/checkbox-ng:get-test-outcome-stats into checkbox-ng:master
Proposed by
Paul Larson
Status: | Merged |
---|---|
Approved by: | Paul Larson |
Approved revision: | b26dca3e411eafbf18383a221a074c9c5969322a |
Merged at revision: | 917b76e1e5095b147a77cd4055818495c25c63b0 |
Proposed branch: | ~pwlars/checkbox-ng:get-test-outcome-stats |
Merge into: | checkbox-ng:master |
Diff against target: |
65 lines (+27/-10) 2 files modified
plainbox/impl/providers/exporters/data/junit.xml (+7/-10) plainbox/impl/session/state.py (+20/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sylvain Pineau | Needs Information | ||
Maciej Kisielewski | Approve | ||
Review via email: mp+344338@code.launchpad.net |
Description of the change
It seems that the stats we generate for junit don't match up with the stats we generate for the c3 submission. This is because the junit stats do not filter out the resource and attachment jobs. This restricts junit output to only look at those, and adds a new helper method in states.py to facilitate getting the right set of stats for only actual tests.
To post a comment you must log in.
I almost forgot to mention... I tested this by creating a small dummy provider with 2 simple tests (one pass, one fail) and 2 attachment jobs (1 pass, 1 fail). Without the patch, I see 4 tests, 2 fails. With the pass, I only see the two actual tests, with 1 failed.