Merge ~pwlars/checkbox-core-snap:support-new-eddystone into checkbox-core-snap:master

[Paul Larson]

This has the snapcraft changes necessary for building with the branch I'd like to merge of checkbox-support which has a new version of the eddystone test.

[Maciej Kisielewski (kissiel)]

I'm trying to understand why we need those -dev packages and how they are used later on. Does the change to checkbox-support make it compile/build anything?

Sorry if my questions are dumb :D

review: Needs Information

[Paul Larson (pwlars)]

typo, those should have been under build-packages. They are needed in order to install pybluez python package (I used that here, because the python3 version of it is not in the bionic archives, which would make building the core18 version difficult)

[Sylvain Pineau (sylvain-pineau)]

Question. If it's possible to backport the focal version of pybluez into our cert ppa in bionic series and pull it from there in the relevant parts here, would that free us from requiring the -dev packages?

review: Needs Information

[Sylvain Pineau (sylvain-pineau)]

and what about series16?

[Paul Larson (pwlars)]

Yes, we can copy the focal pybluez into our ppa, and we definitely should for building the debs. For snaps, the only mechanisms I've seen for building from ppas seems to still be flagged experimental, so I avoided this. What is the issue with the -dev packages (note, they are in build-packages not stage-packages)

No, I haven't tried series16 at all, but I can. I wasn't clear on whether we ever intended to rebuild that again since we shouldn't have new things there.

[Sylvain Pineau (sylvain-pineau)]

Tentative +1 if Paul can confirm the new beacon tests also work on s16.

Note that the patch for s16 will need an update since it also defines a build-package section for checkbox-support:

https://git.launchpad.net/checkbox-core-snap/commit/?h=series16&id=af2768becf0a6fc94c76e45950eb077eaccc7961

Let's also fix the fwts tag once this branch lands:

- source-tag: ""
+ source-tag: "V21.03.00"

To get some checkbox --edge testing in the lab.

[Paul Larson (pwlars)]

Yes, it works on s16 with the fwts tag fixed, but I assumed that was part of the release branching

[Sylvain Pineau (sylvain-pineau)]

I'll update the s16 patches and add tags where needed.

review: Approve

diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index 118d1a2..08806d0 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -148,8 +148,12 @@ parts:
       - python3-distutils
       - python3-pkg-resources
       - python3.8-minimal
+    build-packages:
+      - libbluetooth-dev
+      - python3-dev
     python-packages:
       - pynmea2
+      - pybluez
     after: [acpi-tools]
     stage:
       - -pyvenv.cfg