Merge ~pwlars/checkbox-core-snap:support-new-eddystone-series18 into checkbox-core-snap:series18

Proposed by Paul Larson
Status: Rejected
Rejected by: Jonathan Cave
Proposed branch: ~pwlars/checkbox-core-snap:support-new-eddystone-series18
Merge into: checkbox-core-snap:series18
Diff against target: 18 lines (+5/-0)
1 file modified
snap/snapcraft.yaml (+5/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Disapprove
Review via email: mp+400482@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Our management of the checkbox-core-snap is a lengthy and complicated story, the summary being we don't merge anything to the "historic" branches i.e. series16, series18. The changes will be made to the patches that contain the difference to the master branch.

Don't worry i've seen this so can make sure it the end result is the same.

review: Disapprove
Revision history for this message
Jeff Lane  (bladernr) wrote :

Does this need to be marked "Rejected"?

Unmerged commits

ce5cdc0... by Paul Larson

Add support for the updated eddystone test in checkbox-support

7037345... by Jonathan Cave

TEMP: use working acpi-tools tag

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 0dbaa38..71dee5e 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -133,8 +133,13 @@ parts:
6 stage-packages:
7 - python3-requests-unixsocket
8 - python3-systemd
9+ - libbluetooth-dev
10+ - python3-dev
11 python-packages:
12 - pynmea2
13+ - pybluez
14+ # beacontools 2.0.2 is needed for uc18 to avoid hci5/older-bluez incompatibility
15+ - beacontools[scan]==2.0.2
16 after: [acpi-tools]
17 override-stage: |
18 snapcraftctl stage

Subscribers

People subscribed via source and target branches