Merge lp:~pwlars/charms/trusty/jenkins/add-plugin-site into lp:~canonical-ci-engineering/charms/trusty/jenkins/ubiquity

Proposed by Paul Larson
Status: Merged
Merged at revision: 47
Proposed branch: lp:~pwlars/charms/trusty/jenkins/add-plugin-site
Merge into: lp:~canonical-ci-engineering/charms/trusty/jenkins/ubiquity
Diff against target: 19 lines (+3/-1)
1 file modified
deploy.yaml (+3/-1)
To merge this branch: bzr merge lp:~pwlars/charms/trusty/jenkins/add-plugin-site
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
Review via email: mp+250407@code.launchpad.net

Description of the change

We need to also account for the plugins. By default, jenkins charm will try to go out and grab whatever is latest from the external site. For one, we can't reach that from within our environment, but also we want to keep it restricted to a version we've tested. This allows it to be set using the existing config parameter.

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

Nice work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'deploy.yaml'
2--- deploy.yaml 2015-02-19 23:33:34 +0000
3+++ deploy.yaml 2015-02-20 04:03:34 +0000
4@@ -3,7 +3,8 @@
5 series: trusty
6 services:
7 ubiquity-jenkins:
8- charm: local:trusty/jenkins
9+ charm: ubiquity
10+ branch: lp:~canonical-ci-engineering/charms/trusty/jenkins/ubiquity
11 options:
12 plugins: parameterized-trigger build-publisher mailer urltrigger
13 username: admin
14@@ -11,4 +12,5 @@
15 #use for train because we want to use cat instead
16 release: url
17 release-url: http://people.canonical.com/~josepht/jenkins_1.580.2_all.deb
18+ plugins-site: http://people.canonical.com/~plars/jenkins/plugins
19 ubiquity-branch: lp:~canonical-ci-engineering/ubiquity/ubiquity-ci-testing

Subscribers

People subscribed via source and target branches