Juju Charms Collection
uci-engine-key-secret-subordinate package

Code review comment for lp:~pwlars/charms/precise/uci-engine-key-secret-subordinate/key-secret-lpkey

  1. Precise Pangolin (12.04)
  2. key-secret-lpkey
  3. Merge into trunk
Revision history for this message
Celso Providelo (cprov) wrote :

Thanks for working on this Paul,

I personally would not lay the lp creds as a hidden file (.launchpad.credentials), it will just make it hard to notice this file in production. What about simply 'launchpad.credentials' ?

Also, from what I've looked it seems pretty simple to adjust the charm unittests to cover this new option. Can you do that, please ?

review: Needs Fixing

« Back to merge proposal