Merge lp:~pwlars/charms/precise/uci-engine-key-secret-subordinate/key-secret-lpkey into lp:~canonical-ci-engineering/charms/precise/uci-engine-key-secret-subordinate/trunk
Proposed by
Paul Larson
Status: | Merged |
---|---|
Merged at revision: | 3 |
Proposed branch: | lp:~pwlars/charms/precise/uci-engine-key-secret-subordinate/key-secret-lpkey |
Merge into: | lp:~canonical-ci-engineering/charms/precise/uci-engine-key-secret-subordinate/trunk |
Diff against target: |
52 lines (+10/-3) 3 files modified
config.yaml (+3/-0) hooks/hooks.py (+2/-0) unit_tests/test_hooks.py (+5/-3) |
To merge this branch: | bzr merge lp:~pwlars/charms/precise/uci-engine-key-secret-subordinate/key-secret-lpkey |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Celso Providelo (community) | Approve | ||
Paul Larson | Needs Resubmitting | ||
Review via email: mp+243705@code.launchpad.net |
Commit message
Add optional launchpad credentials
Description of the change
Add optional launchpad credentials
To post a comment you must log in.
Thanks for working on this Paul,
I personally would not lay the lp creds as a hidden file (.launchpad. credentials) , it will just make it hard to notice this file in production. What about simply 'launchpad. credentials' ?
Also, from what I've looked it seems pretty simple to adjust the charm unittests to cover this new option. Can you do that, please ?