Merge ~pushkarnk/ubuntu/+source/url-normalize:add-python-six into ubuntu/+source/url-normalize:ubuntu/devel

Proposed by Pushkar Kulkarni
Status: Needs review
Proposed branch: ~pushkarnk/ubuntu/+source/url-normalize:add-python-six
Merge into: ubuntu/+source/url-normalize:ubuntu/devel
Diff against target: 36 lines (+10/-1)
2 files modified
debian/changelog (+7/-0)
debian/control (+3/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Disapprove
git-ubuntu import Pending
Review via email: mp+468257@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Pushkar Kulkarni (pushkarnk) wrote :

Test build in PPA: https://launchpad.net/~pushkarnk/+archive/ubuntu/test-builds/+build/28607190

Ran autopkgtests locally:

-----

$ autopkgtest \
--apt-upgrade \
--shell-fail \
--setup-commands="sudo apt update && sudo apt install software-properties-common -y && sudo add-apt-repository -y -u -s ppa:pushkarnk/test-builds" \
--no-built-binaries \
url-normalize \
-- lxd autopkgtest/ubuntu/oracular/amd64

...
...
autopkgtest [20:58:12]: @@@@@@@@@@@@@@@@@@@@ summary
unittests PASS
autodep8-python3 PASS (superficial)

-----

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks a lot for the MP, and sorry it took so long for an sponsor to get to it. Meanwhile, I see that the same fix was uploaded to Debian two days and is now present in Ubuntu, so this proposed delta is not necessary anymore. I will mark the MP as Disapproved just to reflect the fact above; please feel free to close/delete it.

review: Disapprove

Unmerged commits

2216843... by Pushkar Kulkarni

update maintainer

47e2ab7... by Pushkar Kulkarni

update changelog

f94d4ac... by Pushkar Kulkarni

Add python3-six builddep to avoid test failures

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 30c0f81..5416f05 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+url-normalize (1.4.3-3ubuntu1) oracular; urgency=medium
7+
8+ * d/control: Add python3-six as a builddep for build-time
9+ tests (LP: #2070517)
10+
11+ -- Pushkar Kulkarni <pushkar.kulkarni@canonical.com> Wed, 26 Jun 2024 19:43:05 +0530
12+
13 url-normalize (1.4.3-3) unstable; urgency=medium
14
15 [ Debian Janitor ]
16diff --git a/debian/control b/debian/control
17index 6dd38c9..0b6edea 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,13 +1,15 @@
21 Source: url-normalize
22 Section: python
23 Priority: optional
24-Maintainer: Sandro Tosi <morph@debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Sandro Tosi <morph@debian.org>
27 Build-Depends: debhelper-compat (= 13),
28 pybuild-plugin-pyproject,
29 python3-all,
30 python3-poetry,
31 python3-pytest <!nocheck>,
32 python3-pytest-cov <!nocheck>,
33+ python3-six,
34 Standards-Version: 4.6.0.1
35 Testsuite: autopkgtest-pkg-python
36 Homepage: https://github.com/niksite/url-normalize

Subscribers

People subscribed via source and target branches