Merge ~pushkarnk/ubuntu/+source/razercfg:lp2070171 into ubuntu/+source/razercfg:ubuntu/devel

Proposed by Pushkar Kulkarni
Status: Merged
Merged at revision: ed1d22c04e9edec75e883300fc979d631eb5f93e
Proposed branch: ~pushkarnk/ubuntu/+source/razercfg:lp2070171
Merge into: ubuntu/+source/razercfg:ubuntu/devel
Diff against target: 40 lines (+10/-2)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/razercfg.install (+1/-1)
Reviewer Review Type Date Requested Status
Simon Chopin (community) Approve
git-ubuntu import Pending
Review via email: mp+468038@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Lena Voytek (lvoytek) wrote :

Thanks for providing this fix Pushkar! I'm wondering if the change would be more sustainable for future Python versions by using a * instead. It seems that Debian used to do this but was changed in https://github.com/bluca/razercfg-debian/commit/8ca6acc389a1fe55b70d6bad00eabb6be5235f9e alongside the directory move. By supporting all python versions we could also send the change to debian to maintain a sync. What do you think?

Revision history for this message
Pushkar Kulkarni (pushkarnk) wrote :

Pushed suggested changes. Ran test builds (0.43-2ubuntu1ppa1) in ppa:pushkarnk/test-builds

Revision history for this message
Pushkar Kulkarni (pushkarnk) wrote :

> Thanks for providing this fix Pushkar! I'm wondering if the change would be
> more sustainable for future Python versions by using a * instead. It seems
> that Debian used to do this but was changed in
> https://github.com/bluca/razercfg-
> debian/commit/8ca6acc389a1fe55b70d6bad00eabb6be5235f9e alongside the directory
> move. By supporting all python versions we could also send the change to
> debian to maintain a sync. What do you think?

Thanks for the review! Yes, it should be possible to use 3.* I've pushed the changes.

Btw, do you suggest we take this patch to Debian instead? I could do that.

Revision history for this message
Simon Chopin (schopin) wrote :

Uploaded, but it's still worthwhile to suggest this change to Debian :)

Revision history for this message
Simon Chopin (schopin) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 3786f3e..e8f5185 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+razercfg (0.43-2ubuntu1) oracular; urgency=medium
7+
8+ * Use the python3.12/dist-packages install path for oracular
9+ (LP: #2070171)
10+
11+ -- Pushkar Kulkarni <pushkar.kulkarni@canonical.com> Mon, 24 Jun 2024 11:27:03 +0530
12+
13 razercfg (0.43-2) unstable; urgency=medium
14
15 * Reset mtime to changelog date for files at epoch (Closes: #1074141)
16diff --git a/debian/control b/debian/control
17index 5f2fbd9..bedec82 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,5 +1,6 @@
21 Source: razercfg
22-Maintainer: Luca Boccassi <bluca@debian.org>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Luca Boccassi <bluca@debian.org>
25 Section: misc
26 Priority: optional
27 Build-Depends: debhelper-compat (= 13),
28diff --git a/debian/razercfg.install b/debian/razercfg.install
29index 822c308..9cbb2d8 100644
30--- a/debian/razercfg.install
31+++ b/debian/razercfg.install
32@@ -2,7 +2,7 @@ razer.conf /etc
33 etc/pm/sleep.d/50-razer /etc/pm/sleep.d
34 ${env:systemdsystemunitdir}
35 etc/udev/rules.d ${env:udevrulesdir}
36-usr/local/lib/python3.11/dist-packages usr/lib/python3
37+usr/local/lib/python3.*/dist-packages usr/lib/python3
38 usr/lib/tmpfiles.d/razerd.conf
39 usr/bin/razerd /usr/bin
40 usr/local/bin/razercfg /usr/bin

Subscribers

People subscribed via source and target branches