Merge ~pushkarnk/ubuntu/+source/javaparser:lp#2065298 into ubuntu/+source/javaparser:ubuntu/devel

Proposed by Pushkar Kulkarni
Status: Needs review
Proposed branch: ~pushkarnk/ubuntu/+source/javaparser:lp#2065298
Merge into: ubuntu/+source/javaparser:ubuntu/devel
Diff against target: 36 lines (+10/-1)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/maven.properties (+1/-0)
Reviewer Review Type Date Requested Status
Graham Inggs (community) Approve
git-ubuntu import Pending
Review via email: mp+465877@code.launchpad.net

Description of the change

Class com.github.javaparser.ast.NodeList extends java.util.List and contains methods - getLast(), getFirst(), addLast() and addFirst() - which were not present in the List interface in openjdk-17 but were added as default methods in openjdk-21. This results in compilation errors when compiling with openjdk-21 which is now default (debian/sid still has openjdk-17 as default).

This needs to be fixed upstream, which claims to be supporting java versions only up to openjdk-18. This can, for now, be avoided by using "maven.compiler.release=17" which will use the -17 version of the List API and hence circumvent this issue.

To post a comment you must log in.
Revision history for this message
Graham Inggs (ginggs) wrote :

Sponsored

review: Approve

Unmerged commits

dc2bb8b... by Pushkar Kulkarni

Update changelog

0826515... by Pushkar Kulkarni

Update maintainer

4c4cf20... by Pushkar Kulkarni

Use maven.compiler.release=17 to compile

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 38b9a00..c5b0d0d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+javaparser (3.25.10+dfsg-1ubuntu1) oracular; urgency=medium
7+
8+ * d/maven.properties: Add file with maven.compiler.release=17
9+ to support compilation with openjdk-21 (LP: #2065298)
10+
11+ -- Pushkar Kulkarni <pushkar.kulkarni@canonical.com> Thu, 09 May 2024 23:31:04 +0530
12+
13 javaparser (3.25.10+dfsg-1) unstable; urgency=medium
14
15 * Team upload
16diff --git a/debian/control b/debian/control
17index 9a440b5..3684d59 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,7 +1,8 @@
21 Source: javaparser
22 Section: java
23 Priority: optional
24-Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
27 Uploaders: Benjamin Mesing <ben@debian.org>
28 Build-Depends:
29 debhelper-compat (= 13),
30diff --git a/debian/maven.properties b/debian/maven.properties
31new file mode 100644
32index 0000000..7ce26a1
33--- /dev/null
34+++ b/debian/maven.properties
35@@ -0,0 +1 @@
36+maven.compiler.release=17

Subscribers

People subscribed via source and target branches