Merge ~pushkarnk/ubuntu/+source/dnspython:fix-2030475 into ubuntu/+source/dnspython:ubuntu/devel

Proposed by Pushkar Kulkarni
Status: Merged
Merged at revision: d4ff52d0699bddbf513d13796ce5b34c5bbef796
Proposed branch: ~pushkarnk/ubuntu/+source/dnspython:fix-2030475
Merge into: ubuntu/+source/dnspython:ubuntu/devel
Diff against target: 31 lines (+7/-2)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-2)
Reviewer Review Type Date Requested Status
Lukas Märdian (community) Approve
Canonical Server Reporter Pending
git-ubuntu import Pending
Review via email: mp+448598@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Pushkar Kulkarni (pushkarnk) wrote :
Revision history for this message
Lukas Märdian (slyon) wrote :

Thanks for your investigation and for providing test builds in a PPA, Pushkar!

Autopkgtests are looking good at:
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-pushkarnk-dnspython/?format=plain

We could have considered dropping python3-httpcore from debian/tests/control, too, in order to more closely test what we're shipping. But DOH already depends on the higher level httpx dependency and DOH test are already disabled ("SKIPPED [1] tests/test_doh.py:129: Python httpx cannot be imported; no DNS over HTTPS (DOH)"), due to python3-httpx missing from d/t/control. So it doesn't make any difference.

LGTM. I'm sponsoring it as-is!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4b1e792..c5f98f1 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+dnspython (2.4.1-1ubuntu2) mantic; urgency=medium
7+
8+ * d/control: Move the httpcore dependency to Suggests (LP: #2030475)
9+
10+ -- Pushkar Kulkarni <pushkar.kulkarni@canonical.com> Mon, 07 Aug 2023 17:40:17 +0530
11+
12 dnspython (2.4.1-1ubuntu1) mantic; urgency=medium
13
14 * Merge from Debian unstable (LP: #2029461). Remaining changes:
15diff --git a/debian/control b/debian/control
16index e249b5e..edf8111 100644
17--- a/debian/control
18+++ b/debian/control
19@@ -31,11 +31,10 @@ Architecture: all
20 Depends: netbase, ${misc:Depends}, ${python3:Depends}
21 Recommends: ca-certificates,
22 python3-cryptography,
23- python3-httpcore (>=0.17.3),
24 python3-idna,
25 python3-requests,
26 python3-requests-toolbelt
27-Suggests: python3-trio, python3-aioquic, python3-h2, python3-httpx
28+Suggests: python3-trio, python3-aioquic, python3-h2, python3-httpx, python3-httpcore (>=0.17.3)
29 Description: DNS toolkit for Python 3
30 dnspython is a DNS toolkit for Python. It supports almost all record types. It
31 can be used for queries, zone transfers, and dynamic updates. It supports TSIG

Subscribers

People subscribed via source and target branches