Merge ~pushkarnk/ubuntu/+source/criu:ubuntu/devel into ubuntu/+source/criu:ubuntu/devel

Proposed by Pushkar Kulkarni
Status: Needs review
Proposed branch: ~pushkarnk/ubuntu/+source/criu:ubuntu/devel
Merge into: ubuntu/+source/criu:ubuntu/devel
Diff against target: 61 lines (+28/-1)
4 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/patches/avert_gcc_warnings_ubuntu.patch (+17/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Simon Quigley (community) Disapprove
git-ubuntu import Pending
Review via email: mp+477160@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Simon Quigley (tsimonq2) wrote :

It's not appropriate to add an Ubuntu delta just to fix some GCC warnings.

Also, this is no longer an issue.

review: Disapprove

Unmerged commits

63b8a36... by Pushkar Kulkarni

update maintainer

1902065... by Pushkar Kulkarni

update changelog

fea25a1... by Pushkar Kulkarni

Disable gcc warnings on Ubuntu

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 7ddd45a..925e04f 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+criu (3.19-7ubuntu1) plucky; urgency=medium
7+
8+ * d/patches: Add patch to disable format-truncation
9+ and stringop-overflow warnings seen reported only
10+ on Ubuntu (LP: #2089588)
11+
12+ -- Pushkar Kulkarni <pushkar.kulkarni@canonical.com> Sat, 30 Nov 2024 22:38:30 +0530
13+
14 criu (3.19-7) unstable; urgency=medium
15
16 * debian/control: Fix test-name for autopkgtest-pkg-python
17diff --git a/debian/control b/debian/control
18index a62608a..375066a 100644
19--- a/debian/control
20+++ b/debian/control
21@@ -1,7 +1,8 @@
22 Source: criu
23 Section: admin
24 Priority: optional
25-Maintainer: Salvatore Bonaccorso <carnil@debian.org>
26+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
27+XSBC-Original-Maintainer: Salvatore Bonaccorso <carnil@debian.org>
28 Build-Depends:
29 asciidoc,
30 debhelper-compat (= 13),
31diff --git a/debian/patches/avert_gcc_warnings_ubuntu.patch b/debian/patches/avert_gcc_warnings_ubuntu.patch
32new file mode 100644
33index 0000000..03bc870
34--- /dev/null
35+++ b/debian/patches/avert_gcc_warnings_ubuntu.patch
36@@ -0,0 +1,17 @@
37+Subject: Avoid GCC warnings seen on Ubuntu only
38+ Warnings related to format truncation and string overflow
39+ are reported only on Ubuntu, probably with _FORTIFY_SOURCE=3.
40+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2089588
41+Author: Pushkar Kulkarni <pushkar.kulkarni@canonical.com>
42+Forwarded: no
43+
44+--- a/Makefile
45++++ b/Makefile
46+@@ -109,6 +109,7 @@
47+ DEFINES += -D_GNU_SOURCE
48+
49+ WARNINGS := -Wall -Wformat-security -Wdeclaration-after-statement -Wstrict-prototypes
50++WARNINGS += -Wno-format-truncation -Wno-stringop-overflow
51+
52+ # -Wdangling-pointer results in false warning when we add a list element to
53+ # local list head variable. It is false positive because before leaving the
54diff --git a/debian/patches/series b/debian/patches/series
55index e6d0f0e..15d512f 100644
56--- a/debian/patches/series
57+++ b/debian/patches/series
58@@ -1,2 +1,3 @@
59 Adjust-to-glibc-__rseq_size-semantic-change.patch
60 net-fix-network-unlock-with-iptables-nft.patch
61+avert_gcc_warnings_ubuntu.patch

Subscribers

People subscribed via source and target branches