Merge lp:~purejava/pantheon-mail/fix-1546062 into lp:~elementary-apps/pantheon-mail/trunk

Proposed by Ralph Plawetzki
Status: Merged
Approved by: Danielle Foré
Approved revision: 1989
Merged at revision: 1992
Proposed branch: lp:~purejava/pantheon-mail/fix-1546062
Merge into: lp:~elementary-apps/pantheon-mail/trunk
Diff against target: 41 lines (+18/-2)
2 files modified
src/client/conversation-viewer/conversation-viewer.vala (+11/-1)
src/engine/rfc822/rfc822-message.vala (+7/-1)
To merge this branch: bzr merge lp:~purejava/pantheon-mail/fix-1546062
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+287516@code.launchpad.net

Commit message

Workaround to display inline images that have a Content-Id ending with '.'

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/client/conversation-viewer/conversation-viewer.vala'
2--- src/client/conversation-viewer/conversation-viewer.vala 2016-02-24 11:48:02 +0000
3+++ src/client/conversation-viewer/conversation-viewer.vala 2016-02-29 19:21:27 +0000
4@@ -2027,7 +2027,17 @@
5 img.set_attribute("class", DATA_IMAGE_CLASS);
6 if (!Geary.String.is_empty(filename))
7 img.set_attribute("alt", filename);
8- img.set_attribute("replaced-id", replaced_images_index.get(content_id));
9+
10+ // FIXME: bugzilla.gnome.org 762782
11+ // in case content_id has a trailing period it gets removed
12+ // this is necessary as g_mime_object_get_content_id removes it too
13+ if (content_id.has_suffix(".")) {
14+ string content_id_without_suffix;
15+ content_id_without_suffix = content_id.slice(0,content_id.length-1);
16+ img.set_attribute("replaced-id", replaced_images_index.get(content_id_without_suffix));
17+ } else {
18+ img.set_attribute("replaced-id", replaced_images_index.get(content_id));
19+ }
20
21 // stash here so inlined image isn't listed as attachment (esp. if it has no
22 // Content-Disposition)
23
24=== modified file 'src/engine/rfc822/rfc822-message.vala'
25--- src/engine/rfc822/rfc822-message.vala 2016-02-16 16:37:14 +0000
26+++ src/engine/rfc822/rfc822-message.vala 2016-02-29 19:21:27 +0000
27@@ -714,7 +714,13 @@
28 return part.get_filename();
29 }
30
31- private GMime.Part? find_mime_part_by_mime_id(GMime.Object root, string mime_id) {
32+ private GMime.Part? find_mime_part_by_mime_id(GMime.Object root, owned string mime_id) {
33+ // FIXME: bugzilla.gnome.org 762782
34+ // in case mime_id has a trailing period it gets removed
35+ // this is necessary as g_mime_object_get_content_id removes it too
36+ if (mime_id.has_suffix("."))
37+ mime_id = mime_id.slice(0,mime_id.length-1);
38+
39 // If this is a multipart container, check each of its children.
40 if (root is GMime.Multipart) {
41 GMime.Multipart multipart = root as GMime.Multipart;

Subscribers

People subscribed via source and target branches