Merge lp:~purejava/pantheon-mail/detach-button-side into lp:~elementary-apps/pantheon-mail/trunk
Proposed by
Ralph Plawetzki
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Danielle Foré | ||||
Approved revision: | 1927 | ||||
Merged at revision: | 1927 | ||||
Proposed branch: | lp:~purejava/pantheon-mail/detach-button-side | ||||
Merge into: | lp:~elementary-apps/pantheon-mail/trunk | ||||
Diff against target: |
12 lines (+1/-1) 1 file modified
src/client/components/pill-toolbar.vala (+1/-1) |
||||
To merge this branch: | bzr merge lp:~purejava/pantheon-mail/detach-button-side | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Danielle Foré | Pending | ||
Review via email:
|
Commit message
Initialize decoration_layout correctly
Description of the change
for details please see linked bug report https:/
To post a comment you must log in.
Analyzing the code shows that PillHeaderbar# close_button_ at_end( ) is called in two cases:
- from MainToolbar when composing new e-mail
- from ComposerHeaderbar when replying to / forwarding e-mail
The former call works, as decoration_layout is initialized where the latter fails, as decoration_layout is not initialized.
This fix initializes decoration_layout correctly.
The fix is tested changing the button-layout with elementary-tweaks. Now, the detach button is displayed on the correct side when composing new mail and when replying inline.