Merge lp:~pundiramit/linaro-android-build-tools/labt into lp:linaro-android-build-tools

Proposed by Amit Pundir
Status: Merged
Merged at revision: 551
Proposed branch: lp:~pundiramit/linaro-android-build-tools/labt
Merge into: lp:linaro-android-build-tools
Diff against target: 34 lines (+7/-7)
1 file modified
build-scripts/create-user-build-script (+7/-7)
To merge this branch: bzr merge lp:~pundiramit/linaro-android-build-tools/labt
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+143675@code.launchpad.net

Description of the change

linaro_android_build_cmds: Support Ubuntu 12.04.01 and 10.04.1 sub-version builds as well and make Overlay component optional.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good.

review: Approve
551. By Paul Sokolovsky

[merge] Support Ubuntu 10.04* and 12.*, allow to continue w/o overlay.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/create-user-build-script'
2--- build-scripts/create-user-build-script 2012-12-28 09:29:09 +0000
3+++ build-scripts/create-user-build-script 2013-01-17 12:31:20 +0000
4@@ -66,15 +66,13 @@
5 echo "ERROR: Only 64bit Host(Build) machines are supported at the moment."
6 exit 1
7 fi
8-if [ \${UBUNTU} == "12.10" ]; then
9- PKGS+=' lib32readline-gplv2-dev'
10-elif [ \${UBUNTU} == "12.04" ] ; then
11- PKGS+=' lib32readline-gplv2-dev'
12-elif [ \${UBUNTU} == "10.04" ] ; then
13+if [[ \${UBUNTU} =~ "12." ]]; then
14+ PKGS+=' lib32readline-gplv2-dev'
15+elif [[ \${UBUNTU} =~ "10.04" ]] ; then
16 PKGS+=' ia32-libs lib32readline5-dev'
17 else
18 echo
19- echo "ERROR: Only Ubuntu 10.04, 12.04 and 12.10 versiona are supported."
20+ echo "ERROR: Only Ubuntu 10.04, 12.04 and 12.10 versions are supported."
21 exit 1
22 fi
23
24@@ -100,7 +98,9 @@
25 fi
26 if [ "a\$SOURCE_OVERLAY" == "a" ]; then
27 echo "ERROR: no source overlay provided. Please download from http://snapshots.linaro.org/android/binaries/$SOURCE_OVERLAY. This must be done from a browser that accepts cookies."
28- exit 1
29+ echo "Do you want to continue without overlay (which may result in broken build)? (y/n) "
30+ read OVERLAY
31+ [ \${OVERLAY} == y ] || exit 1
32 fi
33 EOF
34 fi

Subscribers

People subscribed via source and target branches