Merge lp:~pundiramit/linaro-android-build-tools/labc_pm into lp:linaro-android-build-tools

Proposed by Amit Pundir
Status: Merged
Approved by: Milo Casagrande
Approved revision: 621
Merged at revision: 620
Proposed branch: lp:~pundiramit/linaro-android-build-tools/labc_pm
Merge into: lp:linaro-android-build-tools
Diff against target: 30 lines (+3/-3)
1 file modified
build-scripts/create-user-build-script (+3/-3)
To merge this branch: bzr merge lp:~pundiramit/linaro-android-build-tools/labc_pm
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+165987@code.launchpad.net

Description of the change

Updated linaro_android_build_cmds.sh script to use absolute path of pinned-manifest file. If a user pass relative path of pinned-manifest file while invoking l_a_b_c.sh then it will fail and exit while copying pinned-manifest.xml.

To post a comment you must log in.
621. By Amit Pundir

create-user-build-script: use == for string comparison and fix a typo

Revision history for this message
Milo Casagrande (milo) wrote :

Looks good to me.
+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/create-user-build-script'
2--- build-scripts/create-user-build-script 2013-05-24 15:34:43 +0000
3+++ build-scripts/create-user-build-script 2013-05-28 08:50:34 +0000
4@@ -17,7 +17,7 @@
5 USAGE_SUM="'Usage: \$0 -m <manifest.xml> -o <overlay.tar> [ -t -d directory -l login ]'"
6 USAGE_OVERLAY="'\\n -m <manifest> If -t is not used, then using a browser with cookies you\\n must download the pinned manifest from:\\n $PINNED_MANIFEST_URL\\n -o The path to the vendor required overlay.\\n Can be downloaded from http://snapshots.linaro.org/android/binaries/$SOURCE_OVERLAY\\n'"
7 USAGE_OPTOVERLAY="m:o:"
8- USAGE_OPTHANDLER="o ) SOURCE_OVERLAY=\$OPTARG; SOURCE_OVERLAY_OPTIONAL=0;; m ) MANIFEST=\$OPTARG;;"
9+ USAGE_OPTHANDLER="o ) SOURCE_OVERLAY=\$OPTARG; SOURCE_OVERLAY_OPTIONAL=0;; m ) MANIFEST=\`readlink -f \$OPTARG\`;;"
10 else
11 USAGE_SUM="'Usage: \$0 [ -t -d directory -l login ]'"
12 fi
13@@ -64,7 +64,7 @@
14 esac
15 done
16
17-if [ \${LINARO_ANDROID_ACCESS_ID} -eq "default-bot" -a \${INTERACTIVE} -eq 0 ] ; then
18+if [ "\${LINARO_ANDROID_ACCESS_ID}" == "default-bot" -a \${INTERACTIVE} -eq 0 ] ; then
19 usage
20 fi
21
22@@ -83,7 +83,7 @@
23 PKGS+=' libstdc++6:i386 git-core'
24 elif [[ \${UBUNTU} =~ "12.04" || \${UBUNTU} =~ "10.04" ]] ; then
25 #Install basic dev package missing in chrooted environments
26- suod apt-get install python-software-properties
27+ sudo apt-get install python-software-properties
28 if [[ \${UBUNTU} =~ "12.04" ]]; then
29 PKGS+=' libstdc++6:i386 git-core'
30 else

Subscribers

People subscribed via source and target branches