LAVA Android Test

Merge lp:~pundiramit/lava-android-test/dalvikvm into lp:lava-android-test

  1. dalvikvm
  2. Merge into trunk
Proposed by Amit Pundir
Status: Merged
Merged at revision: 241
Proposed branch: lp:~pundiramit/lava-android-test/dalvikvm
Merge into: lp:lava-android-test
Diff against target: 16 lines (+12/-0)
1 file modified
lava_android_test/test_definitions/shells/dalvik-vm-unit-tests.sh (+12/-0)
To merge this branch: bzr merge lp:~pundiramit/lava-android-test/dalvikvm
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
Review via email: mp+154872@code.launchpad.net

Description of the change

Add dalvik-vm-unit-tests as shell test.

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

OK for me!

review: Approve
Revision history for this message
Antonio Terceiro (terceiro) wrote :

On Fri, Mar 22, 2013 at 07:03:19AM -0000, Amit Pundir wrote:
> Amit Pundir has proposed merging lp:~pundiramit/lava-android-test/dalvikvm into lp:lava-android-test.
>
> Requested reviews:
> Yongqin Liu (liuyq0307)
>
> For more details, see:
> https://code.launchpad.net/~pundiramit/lava-android-test/dalvikvm/+merge/154872
>
> Add dalvik-vm-unit-tests as shell test.
> --
> https://code.launchpad.net/~pundiramit/lava-android-test/dalvikvm/+merge/154872
> Your team Linaro Validation Team is subscribed to branch lp:lava-android-test.

> === added file 'lava_android_test/test_definitions/shells/dalvik-vm-unit-tests.sh'
> --- lava_android_test/test_definitions/shells/dalvik-vm-unit-tests.sh 1970-01-01 00:00:00 +0000
> +++ lava_android_test/test_definitions/shells/dalvik-vm-unit-tests.sh 2013-03-22 07:02:37 +0000
> @@ -0,0 +1,12 @@
> +#!/system/bin/sh
> +#
> +# Dalvik-VM unit tests.
> +#
> +
> +chmod 777 /data/nativetest/dalvik-vm-unit-tests/dalvik-vm-unit-tests
> +/data/nativetest/dalvik-vm-unit-tests/dalvik-vm-unit-tests
> +if [ $? -eq 0 ]; then
> + echo "dalvik-vm-unit-tests=pass"
> +else
> + echo "dalvik-vm-unit-tests=fail"
> +fi

Hey guys - I noticed that this test was already added to the central
test definitions repository:

http://lists.linaro.org/pipermail/linaro-validation/2013-March/001702.html
http://git.linaro.org/gitweb?p=qa/test-definitions.git;a=commitdiff;h=HEAD;hp=54168055c2b733297c6567d345bbe4a3332f00e9

Do we really want to have this duplicated in lava-android-test?

--
Antonio Terceiro
Software Engineer - Linaro
http://www.linaro.org

Revision history for this message
Amit Pundir (pundiramit) wrote :

I did not know how to use lava-test-shell into LAVA_TEST_PLAN back then so I pushed the test in both formats. I learned how to use that from Yongqin yesterday.

Antonio, It is OK if you skip this one.

Thanks for the review guys.

Revision history for this message
Antonio Terceiro (terceiro) wrote :

On Tue, Apr 02, 2013 at 09:07:26AM -0000, Amit Pundir wrote:
> I did not know how to use lava-test-shell into LAVA_TEST_PLAN back then so I pushed the test in both formats. I learned how to use that from Yongqin yesterday.
>
> Antonio, It is OK if you skip this one.

This was already merged, but I think we should remove it. Can you please
confirm that you guys are not submitting jobs that rely on having this
in lava-android-test?

--
Antonio Terceiro
Software Engineer - Linaro
http://www.linaro.org

Revision history for this message
Amit Pundir (pundiramit) wrote :

On 3 April 2013 08:01, Antonio Terceiro <email address hidden> wrote:

> On Tue, Apr 02, 2013 at 09:07:26AM -0000, Amit Pundir wrote:
> > I did not know how to use lava-test-shell into LAVA_TEST_PLAN back then
> so I pushed the test in both formats. I learned how to use that from
> Yongqin yesterday.
> >
> > Antonio, It is OK if you skip this one.
>
> This was already merged, but I think we should remove it. Can you please
> confirm that you guys are not submitting jobs that rely on having this
> in lava-android-test?
>

Hi Antonio,

I'm not yet able to test run this dalvik test as a lava-test-shell on LAVA
production server
https://android-build.linaro.org/builds/~linaro-android-restricted/pundiramit-test-0/.
For the time being I suggest we keep it in lava-android-test as well. I'll
let you know if when to remove this test from lava-android-test. Sounds
good?

Regards,
Amit Pundir

>
> --
> Antonio Terceiro
> Software Engineer - Linaro
> http://www.linaro.org
>
>
> https://code.launchpad.net/~pundiramit/lava-android-test/dalvikvm/+merge/154872
> You are the owner of lp:~pundiramit/lava-android-test/dalvikvm.
>

Revision history for this message
Antonio Terceiro (terceiro) wrote :

On Mon, Apr 08, 2013 at 09:58:23AM -0000, Amit Pundir wrote:
> On 3 April 2013 08:01, Antonio Terceiro <email address hidden> wrote:
>
> > On Tue, Apr 02, 2013 at 09:07:26AM -0000, Amit Pundir wrote:
> > > I did not know how to use lava-test-shell into LAVA_TEST_PLAN back then
> > so I pushed the test in both formats. I learned how to use that from
> > Yongqin yesterday.
> > >
> > > Antonio, It is OK if you skip this one.
> >
> > This was already merged, but I think we should remove it. Can you please
> > confirm that you guys are not submitting jobs that rely on having this
> > in lava-android-test?
> >
>
> Hi Antonio,
>
> I'm not yet able to test run this dalvik test as a lava-test-shell on LAVA
> production server
> https://android-build.linaro.org/builds/~linaro-android-restricted/pundiramit-test-0/.
> For the time being I suggest we keep it in lava-android-test as well. I'll
> let you know if when to remove this test from lava-android-test. Sounds
> good?

OK. Can you share what is the problem you have with running it with
lava-test-shell?

--
Antonio Terceiro
Software Engineer - Linaro
http://www.linaro.org

Revision history for this message
Amit Pundir (pundiramit) wrote :

On 8 April 2013 19:58, Antonio Terceiro <email address hidden> wrote:

> On Mon, Apr 08, 2013 at 09:58:23AM -0000, Amit Pundir wrote:
> > On 3 April 2013 08:01, Antonio Terceiro <email address hidden>
> wrote:
> >
> > > On Tue, Apr 02, 2013 at 09:07:26AM -0000, Amit Pundir wrote:
> > > > I did not know how to use lava-test-shell into LAVA_TEST_PLAN back
> then
> > > so I pushed the test in both formats. I learned how to use that from
> > > Yongqin yesterday.
> > > >
> > > > Antonio, It is OK if you skip this one.
> > >
> > > This was already merged, but I think we should remove it. Can you
> please
> > > confirm that you guys are not submitting jobs that rely on having this
> > > in lava-android-test?
> > >
> >
> > Hi Antonio,
> >
> > I'm not yet able to test run this dalvik test as a lava-test-shell on
> LAVA
> > production server
> >
> https://android-build.linaro.org/builds/~linaro-android-restricted/pundiramit-test-0/
> .
> > For the time being I suggest we keep it in lava-android-test as well.
> I'll
> > let you know if when to remove this test from lava-android-test. Sounds
> > good?
>
> OK. Can you share what is the problem you have with running it with
> lava-test-shell?
>

So LAVA dashboard for a job running dalvik test as lava-android-test
https://validation.linaro.org/lava-server/dashboard/streams/private/team/linaro/android-daily/bundles/aded4ec3fb533f5982a68cab2c7731a2e73fbb86/c0ef53ec-b9a9-44a6-bdc0-1ebe2c4b20d5/
clearly
indicates the PASS/FAIL status of the test but a similar job to run dalvik
test through lava-test-shell doesn't show PASS/FAIL status of the test
https://validation.linaro.org/lava-server/dashboard/streams/private/team/linaro/android-daily/bundles/f281eb99d4eb493b1f2f603f45517f44ffe0600e/

I now see that the lava-test-shell script to run dalvik test doesn't have
execute permissions set. I'll ask Senthil to fix this.

> --
> Antonio Terceiro
> Software Engineer - Linaro
> http://www.linaro.org
>
>
> https://code.launchpad.net/~pundiramit/lava-android-test/dalvikvm/+merge/154872
> You are the owner of lp:~pundiramit/lava-android-test/dalvikvm.
>

Revision history for this message
Senthil Kumaran S (stylesen) wrote :

Hi Amit,

On Wed, 2013-04-10 at 06:13 +0000, Amit Pundir wrote:
> I now see that the lava-test-shell script to run dalvik test doesn't have
> execute permissions set. I'll ask Senthil to fix this.

I just fixed this and pushed to the git repository. Please check and let
me know if the script runs properly.

Thank You.
--
Senthil Kumaran
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'lava_android_test/test_definitions/shells/dalvik-vm-unit-tests.sh'
2--- lava_android_test/test_definitions/shells/dalvik-vm-unit-tests.sh 1970-01-01 00:00:00 +0000
3+++ lava_android_test/test_definitions/shells/dalvik-vm-unit-tests.sh 2013-03-22 07:02:37 +0000
4@@ -0,0 +1,12 @@
5+#!/system/bin/sh
6+#
7+# Dalvik-VM unit tests.
8+#
9+
10+chmod 777 /data/nativetest/dalvik-vm-unit-tests/dalvik-vm-unit-tests
11+/data/nativetest/dalvik-vm-unit-tests/dalvik-vm-unit-tests
12+if [ $? -eq 0 ]; then
13+ echo "dalvik-vm-unit-tests=pass"
14+else
15+ echo "dalvik-vm-unit-tests=fail"
16+fi

Subscribers

People subscribed via source and target branches