Merge lp:~psybers/do/thread into lp:do

[Robert Dyer]

[Alex Launi (alexlauni)]

Can you explain why we want this API change?

[Robert Dyer (psybers)]

> Can you explain why we want this API change?

The reason I developed this branch was due to my need in a plugin to have access to the created thread. I needed to be able to stop and/or join the thread created and was simply duplicating the code this API provides to get that functionality.

This code can be in the pipeline for when we have other ABI changes and pushed at that time. It is very low priority.

[Alex Launi (alexlauni)]

Looks fine to me

review: Approve

=== modified file 'Do.Platform/src/Do.Platform/AbstractApplicationService.cs'
--- Do.Platform/src/Do.Platform/AbstractApplicationService.cs	2009-01-17 22:48:10 +0000
+++ Do.Platform/src/Do.Platform/AbstractApplicationService.cs	2009-06-18 19:52:32 +0000
@@ -47,7 +47,10 @@
 		/// <param name="action">
 		/// A <see cref="Action"/> to run on a worker thread.
 		/// </param>
-		public abstract void RunOnThread (Action action);
+		/// <returns>
+		/// A reference to the created <see cref="Thread"/>.
+		/// </returns>
+		public abstract Thread RunOnThread (Action action);
 
 		/// <summary>
 		/// Run an action on a worker thread after a delay (ms).
@@ -59,9 +62,12 @@
 		/// A <see cref="System.Int32"/> delay (in millseconds)
 		/// to wait before running the action.
 		/// </param>
-		public void RunOnThread (Action action, int delay)
+		/// <returns>
+		/// A reference to the created <see cref="Thread"/>.
+		/// </returns>
+		public Thread RunOnThread (Action action, int delay)
 		{
-			RunOnThread (action, new TimeSpan (0, 0, 0, 0, delay));
+			return RunOnThread (action, new TimeSpan (0, 0, 0, 0, delay));
 		}
 
 		/// <summary>
@@ -74,9 +80,12 @@
 		/// A <see cref="TimeSpan"/> delay to wait before running
 		/// the action.
 		/// </param>
-		public void RunOnThread (Action action, TimeSpan delay)
+		/// <returns>
+		/// A reference to the created <see cref="Thread"/>.
+		/// </returns>
+		public Thread RunOnThread (Action action, TimeSpan delay)
 		{
-			RunOnThread (() => {
+			return RunOnThread (() => {
 				Thread.Sleep (delay);
 				action ();
 			});

=== modified file 'Do.Platform/src/Do.Platform/Do.Platform.Default/DefaultApplicationService.cs'
--- Do.Platform/src/Do.Platform/Do.Platform.Default/DefaultApplicationService.cs	2009-01-17 22:35:46 +0000
+++ Do.Platform/src/Do.Platform/Do.Platform.Default/DefaultApplicationService.cs	2009-06-18 19:52:32 +0000
@@ -20,6 +20,7 @@
 using System;
 using System.IO;
 using System.Collections.Generic;
+using System.Threading;
 
 using Do.Universe;
 
@@ -35,10 +36,11 @@
 			}
 		}
 
-		public override void RunOnThread (Action action)
+		public override Thread RunOnThread (Action action)
 		{
 			Log<DefaultApplicationService>.Debug ("Cannot run action on a thread.");
 			action ();
+			return null;
 		}
 
 		public override void RunOnMainThread (Action action)

=== modified file 'Do/src/Do.Platform/ApplicationService.cs'
--- Do/src/Do.Platform/ApplicationService.cs	2009-01-17 22:35:46 +0000
+++ Do/src/Do.Platform/ApplicationService.cs	2009-06-18 19:52:32 +0000
@@ -46,18 +46,23 @@
 			get { return items; }
 		}
 
-		public override void RunOnThread (Action action)
+		public override Thread RunOnThread (Action action)
 		{
 			if (action == null) throw new ArgumentNullException ("action");
 
-			new Thread (() => {
+			Thread newThread = new Thread (() => {
 				try {
 					action ();
+				} catch (ThreadAbortException e) {
 				} catch (Exception e) {
 					Log.Error ("Error in RunOnThread: {0}", e.Message);
 					Log.Debug (e.StackTrace);
 				}
-			}).Start ();
+			});
+			
+			newThread.Start ();
+			
+			return newThread;
 		}
 
 		public override void RunOnMainThread (Action action)