Code review comment for lp:~psusi/ubuntu/natty/upower/sleep

Revision history for this message
Evan Broder (broder) wrote :

I disagree with changing an established and cross-distro D-Bus interface here.

And even though you fix g-p-m, I don't see patches for kdebase-workspace-bin or xfce4-power-manager. And even if you patched all of the utilities in the Ubuntu archive that used UPower, there could be any number of third-party programs that are expecting UPower to conform to its cross-distro definition (http://upower.freedesktop.org/docs/UPower.html).

The better approach here is to add a new signal that includes the argument, but leave the old signal alone, and that seems to be the conclusion that upstream is coming to as well.

review: Disapprove

« Back to merge proposal