Merge lp:~psivaa/utah/remove-psutil-error-imports-utopic into lp:utah

Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 1048
Merged at revision: 1048
Proposed branch: lp:~psivaa/utah/remove-psutil-error-imports-utopic
Merge into: lp:utah
Diff against target: 28 lines (+2/-3)
1 file modified
utah/process.py (+2/-3)
To merge this branch: bzr merge lp:~psivaa/utah/remove-psutil-error-imports-utopic
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+221641@code.launchpad.net

Commit message

psutil.error is being deprecated in utopic. This should therefore fix https://bugs.launchpad.net/utah/+bug/1325424. Which is the cause for utah server not being able to download client side logs recently in desktop and server smoke tests.

Description of the change

psutil.error is being deprecated in utopic. This should therefore fix https://bugs.launchpad.net/utah/+bug/1325424. Which is the cause for utah server not being able to download client side logs recently in desktop and server smoke tests.

Would require to have a closer look at the fix since the fix has not fully be verified. The utah-client and utah-common pkges are installed as deb files into the (utopic) clients.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Let's make sure this really fixes the bug before closing it of course, but it works on precise and seems to be the right (only) thing for utopic+.
+1

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

psivaa - do you need me to merge this, or do you have permission?

Revision history for this message
Para Siva (psivaa) wrote :

doanac: I've now got the permission to merge it, but could get help building utah with this change. thanks

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utah/process.py'
2--- utah/process.py 2014-04-23 15:48:19 +0000
3+++ utah/process.py 2014-06-01 22:10:17 +0000
4@@ -27,7 +27,6 @@
5 import threading
6
7 import psutil
8-import psutil.error
9
10 from utah import logger
11
12@@ -46,7 +45,7 @@
13 """
14 try:
15 proc = psutil.Process(pid)
16- except psutil.error.NoSuchProcess:
17+ except psutil.NoSuchProcess:
18 return None
19
20 cmdline = ' '.join(proc.cmdline)
21@@ -86,7 +85,7 @@
22 for pid in pids:
23 try:
24 cmdlines.append(' '.join(psutil.Process(pid).cmdline))
25- except psutil.error.NoSuchProcess:
26+ except psutil.NoSuchProcess:
27 pass
28 return any(pattern in cmdline for cmdline in cmdlines)
29

Subscribers

People subscribed via source and target branches

to all changes: