Merge lp:~psivaa/utah/python-apt-installed-version-deprecation-fix into lp:utah

[Para Siva]

python-apt has Package.installedVersion deprecated since 0.7.9 and it makes utah break in trusty. Tested the fix to be working with a precise installation as well.

[Paul Larson (pwlars)]

+1

review: Approve

[Andy Doan (doanac)]

Is this fix backwards compatible or do we need to add some logic to try either style of "installed version"?

[Paul Larson (pwlars)]

He mentioned testing it on precise as well, so based on that I'm guessing
it should work for our needs.

On Mon, Nov 11, 2013 at 5:57 PM, Andy Doan <email address hidden>wrote:

> Is this fix backwards compatible or do we need to add some logic to try
> either style of "installed version"?
> --
>
> https://code.launchpad.net/~psivaa/utah/python-apt-installed-version-deprecation-fix/+merge/194739
> You are reviewing the proposed merge of
> lp:~psivaa/utah/python-apt-installed-version-deprecation-fix into lp:utah.
>

[Para Siva (psivaa)]

Yes, I tested the fix in a precise machine to return the same string as before. Also the deprecation occurred in 0.7.9 and the first precise image came with 0.8.3. So the fix will work with precise and later but the older version ('installedVersion') stops working some where after precise.

=== modified file 'utah/provisioning/debs.py'
--- utah/provisioning/debs.py	2013-05-24 14:29:23 +0000
+++ utah/provisioning/debs.py	2013-11-11 18:43:53 +0000
@@ -25,7 +25,7 @@
 
 
 def _utah_deb(deb):
-    utah_version = apt.cache.Cache()['utah'].installedVersion
+    utah_version = apt.cache.Cache()['utah'].installed.version
     if utah_version is None:
         raise UTAHProvisioningException("UTAH package isn't installed")